Forums - Review feature language [#1798854]

Comment #1

tvn commented 8 October 2012 at 13:55

Assigned:	tvn	» Unassigned
Status:	Active	» Needs work

I edited feature and scenario descriptions a bit.

We also need tests to check that:
Page /forum exist and "New forum topics" block in sidebar shows up
Categories "Forums' and 'Drupal version' work when creating new topic
Newly created topics show up in "New forum topics" block

These tests could be added to forum_topic_post.feature and this file renamed to more general "forum.feature". It feels like we have too many files with 1-2 scenario per file for this section.

forum_ad.feature file:
This also needs to test if ads show up in "Paid Drupal services" forum
And I'm not sure if it's possible - test if ads show up on individual forum topics of services subforums.
Note also that those ads are not really popular among sponsors now, so sometimes slots might just be empty, even though functionality itself works.

forum_breadcrumb.feature file:
Scenario: User follows link in the Support forum without logging in
probably needs
"And I should not see the breadcrumb "Post installation" step

Some scenarios in this file are for not logged in users - should we tag them as @anon?

Log in or register to post comments

Comment #2

tvn commented 8 October 2012 at 13:56

Issue tags:

+forums

Log in or register to post comments

Comment #3

sachin2dhoni commented 10 October 2012 at 10:23

Assigned:	Unassigned	» sachin2dhoni
Issue tags:		+sprint 12

Taking this up

Log in or register to post comments

Comment #4

sachin2dhoni commented 12 October 2012 at 08:59

Status:

Needs work

» Needs review

Uploading to dev branch with changes.

Renamed the file forum_topic_post.feature to forum.feature.

Please check the commit log:61173e8

Log in or register to post comments

Comment #5

eliza411 commented 14 October 2012 at 18:31

Status:

Needs review

» Needs work

This step seems inconsistent with the way we're checking for other content in specific regions, which is more like I should see something in the "right sidebar" region. Why is that? There might be a good reason that I'm just not seeing, so it's not necessarily in need of work :)

+
+ /**
+ * @Then /^I should see latest forum topic in the rightside block$/
+ */
+ public function iShouldSeeLatestForumTopicInTheRightsideBlock() {
+ sleep(2);
+ $forumTitle = HackyDataRegistry::get('random:Forum subject');
+ if(empty($forumTitle)) {
+ throw new Exception('No Forum title exists in this page');
+ }
+ $this->iShouldSeeInArea('link', $forumTitle, "right sidebar");
+ }
}

Log in or register to post comments

Comment #6

sachin2dhoni commented 15 October 2012 at 15:23

Status:

Needs work

» Needs review

As the blocks does not fall under structured region/area , so the the above step definition is written to find latest forum topic link in the rightside of the forum page.