The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The three parameters in WebTest::getInfo() ['name', 'description', and 'group'] should be plain English strings There are a few core tests that still wrap these parameters in t().
This issue is to address two occurances of this in the Database subsystem. This then should be backported to D7.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Remove_t_from_params_in_getinfo-1798858-D7-10.patch | 1.56 KB | paranojik |
| #2 | Remove_t_from_params_in_getinfo-1798858-2.patch | 1.96 KB | paranojik |
Comments
Comment #1
lars toomre commentedThe two tests that need to be addressed are:
- EmptyStatementTest.php
- NextIdTest.php
Comment #2
paranojik commentedThere you go...
Comment #3
lars toomre commentedLooks great! Thank you. RTBC!
Comment #4
damienmckenna*cough* not a documentation issue
Comment #5
jhodgdonBut it's a good patch, thanks!
Committed to 8.x. Most likely we need to figure out where this test is in D7 and backport? If it doesn't exist, just set this back to 8.x/fixed. Thanks! [Lars: there's a tag for backporting. :) ]
Comment #6
lars toomre commentedOK @DamienMcKenna. I am at a loss why this is not a documentation issue.
If you care, please review the meta issue #500866: [META] remove t() from assert message and add comments as appropriate.
Comment #7
jhodgdonComment #8
lars toomre commentedSorry x-post.
Comment #9
jhodgdonNow it's really a cross-post. :)
Comment #10
paranojik commented...and there's the D7 backport...
Comment #11
jhodgdonThanks! I'll get that one committed tomorrow probably.
Comment #12
jhodgdonCommitted to 7.x - thanks again!