The qTip library (v1) only allows one instance of each callback. Because the module ships with several callbacks already implemented it means that individual sites cannot also implement them. Separate the callback implementations into another JS file and then provide a setting to allow loading of that file to be disabled.

Comments

damienmckenna’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new5.99 KB

This makes several changes:

  • The callbacks have been moved into the js/menu_minipanels_callbacks.js file.
  • There's a new setting on the admin page to control whether this file is loaded along with the rest; by default it is loaded, thus the module should work identically as before.
  • Documentation has been added in several locations with details of what to do to customize the callbacks.

D6 for now, will further tweak it and work on the D7 patch later.

damienmckenna’s picture

StatusFileSize
new0 bytes

Fixed patch for D6.

damienmckenna’s picture

StatusFileSize
new6 KB

#facepalm.

damienmckenna’s picture

StatusFileSize
new6.06 KB

Renamed the new JS file.

damienmckenna’s picture

StatusFileSize
new6.17 KB

A small update for text improvements.

damienmckenna’s picture

StatusFileSize
new6.17 KB

Missed a file change.

damienmckenna’s picture

StatusFileSize
new6.17 KB

Updated patch, parallel to the D7 version.

damienmckenna’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new9.45 KB

D7 version of the above.

damienmckenna’s picture

Status: Needs review » Fixed

Committed.

damienmckenna’s picture

Status: Fixed » Closed (fixed)

Closing this in the interest of tidying up the issue queue after the release of 7.x-1.0 / 6.x-1.3.