I disabled media module and tried the attachments migration with latest code:

I get a page full of:

Illegal offset type in isset or empty File /home/quickstart/websites/phpbb3d7.dev/modules/field/field.info.inc, line 686

one for each attachment, the migration failed.

Comments

marktheshark’s picture

marktheshark commented

As an aside: Should media be listed as a dependency for this module, or it is not because it's optional?

challenge’s picture

challenge commented

It's optional, If you watch phpbb2drupal code you'll see the option to use it, but the code isn't complete.

About media... last time I read docs, media module was called as "the future of drupal media handling"...
I'm not deep into it, I used it time ago, but I saw from others how much media is powerful. Really powerful.
Let's say too that's used by circa 80k websites. (module stats)

As you see I opened two issues, one with media module and one without...

if I could choose I'd like to use it for future proofing and for a better media handling.
But I still can't program and I'm not the maintainer, so I can only hope for a better attachment migration, automatic file rename, all integrated with media module. As now attachments migration is the only big issue stopping me from migrating my forums to drupal.

If it was for me I'd ditch the core file field handling and work only on media module integration, some code is already there from the previous maintainer.

Media module is beautiful for handling and showing such a lot of different file types in a forum (video/embeds/local imgs/remote imgs/audio etc).

JeremyFrench’s picture

JeremyFrench commented
Status: Active » Fixed

Have just committed a possible fix to this. Anyone able to test?

marktheshark’s picture

marktheshark commented

Is the fix specifically for the non-media approach?

JeremyFrench’s picture

JeremyFrench commented

Yes for non media only. I think there is a different issue when media

challenge’s picture

challenge commented

this error is gone. (media disabled)

I now have another issue, but I need a deep diagnose, I'll open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.