In system.css is much documentation missing and thead th overwrite is missing.

This patch adds both.

CommentFileSizeAuthor
#3 system_rtl_thead_th.patch.patch1.63 KBhass
#1 system-rtl.patch1.68 KBhass
system-rtl_css.patch1.81 KBhass

Comments

hass’s picture

hass commented
StatusFileSize
new system-rtl.patch1.68 KB

updated patch for latest HEAD

dvessel’s picture

dvessel commented

The base LTR styles show this:

thead th {
  text-align: left; /* LTR */
  padding-right: 1em; /* LTR */
  border-bottom: 3px solid #ccc;
}

Is there a reason why your patch forces a right padding of .5em? Is that what's most browsers use as their defaults?

+thead th {
+  text-align: right;
+  padding-right: 0.5em;
+  padding-left: 1em;
+}
hass’s picture

hass commented
StatusFileSize
new system_rtl_thead_th.patch.patch1.63 KB

Good catch! Sorry, my fault... i found this has been introduced by my theme with a line th, td { padding: .3em .5em; }. Reworked the patch and checked all overwrites... we could keep padding-left, but this could be inherited from default-rtl, too. So removed this line, too.

The kept alignment is nevertheless required.

yhager’s picture

yhager commented
Status: Needs review » Closed (duplicate)

thןדwas actually committed with http://drupal.org/node/181370 (but with the enforcement of padding-right:0.5em - I made the exact same mistake you did). However, since this problem cannot be solved (you either break the theme or the core), I recommend to leave it as is).