Convert SQL queries

Can you elaborate your point about stormperson_validate()?

+      ->condition('name', '%' . db_like($string) . '%', 'LIKE')

Looks here like we're changing from string% to %string%

+   

One bit of trailing whitespace that's been added.

I think there was a rogue bracket in #9. This should fix.

A few questions on this patch:

+++ b/stormorganization/stormorganization.admin.inc
@@ -258,15 +258,19 @@ function stormorganization_list_filter_reset($form, &$form_state) {
+    $return = $query
+      ->addTag('node_access')
+      ->fields('n', array('nid', 'title'))
+      ->condition('n.type', 'stormorganization')
+      ->condition('title', '%' . db_like($string) . '%', 'LIKE')
+      ->range(0, 10);
+
+    foreach($return as $row) {
+      $matches[$row->title] = check_plain($row->title);

Need to execute() query.

+++ b/stormperson/stormperson.admin.inc
@@ -190,17 +190,20 @@ function _stormperson_organization_people_js($organization_nid=0) {
-    $s = "SELECT n.nid, n.title FROM {node} n INNER JOIN {stormperson} AS spe ON n.vid=spe.vid WHERE n.status=1 AND n.type='stormperson' AND spe.organization_nid=%d ORDER BY n.title";
-    $s = stormperson_access_sql($s);
-    $s = db_rewrite_sql($s);
-    $r = db_query($s, $organization_nid);
-
-    while ($item = db_fetch_object($r)) {
-      $nid = $item->nid;
-      $people[$nid] = $item->title;
+      $query = db_select('node', 'n')
+        ->fields('n', array('nid', 'title'))
+        ->condition('n.status', 1)
+        ->condition('n.type', 'organization')
+        ->condition('spe.organization', $organization_nid)
+        ->join('stormperson', 'spe', 'n.vid = spe.vid');
+
+  $result = $query->execute();
+    foreach($result as $row) {
+      $nid = $row->name;
+      $people[$nid] = $row->title;

Needs to be tagged for a node_access check.

+++ b/stormperson/stormperson.module
@@ -509,7 +524,8 @@ function stormperson_update($node) {
-  $ass_user = user_load(array('name' => $node->user_name));
+  $username = $node->username;

$node->username or $node->user_name ?

#13: storm-1799550-sqlapi-d7.patch queued for re-testing.

Looks like there is an old patch included in the diff!

Also - would you be able to briefly explain the parts that this fix to aid in testing?

I tried to test this, but the Storm Person form isn't really working yet so I didn't see a form.

Do you see a form etc?

I don't see those fields - so wondering if you've fixed this bit on your dev version?

Once I'd a) committed your other patch and b) refreshed my storm install the fields were there! Not sure which fixed, but meant that I tested and committed your patch.

For me, it inserted the user_uid correctly, but throws an error on the user_nid. After some investigations, I found this was a bug present in 6.x-2.x also. Will create a separate issue for that.

What are you going to work on next? ;-)