Currently the redhen_filter_form used to filter lists of RedHen entities shows a fieldset entitled 'Filter by %bundle specific fields' containing field elements or - if there are no bundle-specific fields - a message, 'There are no additional fields for %bundle.'
This fieldset is probably superfluous in the case that there is only one bundle. In that case, we should just add the fields without making a bundle distinction.
Patch changes the message displayed if there is no field on the entity bundle to display only if there are multiple bundles. Also moves the message one down in the if clauses, so it will display if there are no fields, rather than displaying if there are fields but none qualifies.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | redhen-filter-form-bundle-1799576-3.patch | 2.12 KB | nedjo |
| #2 | redhen-filter-form-bundle-1799576-2.patch | 2.17 KB | nedjo |
| #1 | redhen-filter-form-bundle-1799576-1.patch | 2.3 KB | nedjo |
Comments
Comment #1
nedjoPatch attached.
Comment #2
nedjoMinor tweaks: if not using a fieldset, retain the #id and set the #type to 'container'.
It looks like the no fields per bundle results message is now obsolete since there will always be a locked email field. I'll update the issue summary accordingly.
Comment #3
nedjoReally, the message about no fields is tangential to this issue so I'm going to leave it as is, except it should be displayed only if there are multiple bundles. Updated patch attached. (Also moves the message one down in the if clauses, so it will display if there are no fields, rather than displaying if there are fields but none qualifies.)
Comment #3.0
nedjoMessage is obsolete.
Comment #4
levelos commentedComment #5
gcbpatch applied in Dev. Thanks nedjo!
Comment #5.0
gcbUpdate issue summary re no field message.