In the file ahah_example_simple_validation.inc (which is the example which checks that a textfield has at least 2 words in it), there are the comments:
[line 48]
* Submit handler for autocheckboxes.

[line 61]
/**
* Callback for autocheckboxes. Process the form with the number of checkboxes
* we want to provide.
*/

These are comments which are found in the autocheckboxes.inc (where they belong) and not here.

Comments

drupalshrek’s picture

drupalshrek commented

As another small comment, the ahah_example_simple_validation.inc file is not named consistently with the other sub-parts of the ahah_example. It should be named simple_validation.inc to be consistent, since each of the others is also named only with the name of the subpart. For example, the autocheckboxes sub-part is not named ahah_example_autocheckboxes.inc but is simply named autocheckboxes.inc

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@drupalshrek, patches are welcome. I'm not sure there's actually as much consistency to judge things by as you are expecting :-)

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Category: bug » task
Status: Active » Fixed
  • Made the documentation change.
  • Made the file names consistent (all have a prefix of ahah_example_ now).
  • Folded the README file into the module docblock, where it belongs.

Ideally, we'd have better Doxy markup (@defgroup, etc). But this is a D6 issue, and we'd like to wind them down.

Committed: http://drupalcode.org/project/examples.git/commitdiff/5d7f9be69462896892...

Thanks, drupalshrek. :-)

Every time I see 'drupalshrek' I think of this: https://twitter.com/search?q=%23putashrekinit&src=hash

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.