Multiple garbage collection calls may run in parallel, resulting in erroneous DROP TABLE queries.

CommentFileSizeAuthor
#5 views_data_export-1800276-locks.patch3.33 KBsteven jones
#1 views_data_export-fix_sql_drop_table_errors-1800276-1.patch3.61 KBpdrake
#1 views_data_export-3.0-beta-5_fix_sql_drop_table_errors-1800276-1.patch3.28 KBpdrake

Comments

pdrake’s picture

pdrake commented
Status: Active » Needs review
StatusFileSize
new views_data_export-3.0-beta-5_fix_sql_drop_table_errors-1800276-1.patch3.28 KB
new views_data_export-fix_sql_drop_table_errors-1800276-1.patch3.61 KB

Attached is a patch for 6.x-3.x-dev and an additional patch for anyone running 6.x-3.0-beta5.

steven jones’s picture

steven jones commented

#1: views_data_export-fix_sql_drop_table_errors-1800276-1.patch queued for re-testing.

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Looks great, thanks for the patch! Committted to 6.x-2.x.

steven jones’s picture

steven jones commented
Status: Fixed » Patch (to be ported)

This should go into 7.x-3.x too.

steven jones’s picture

steven jones commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new views_data_export-1800276-locks.patch3.33 KB

Here's a patch,

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Thanks again! Committed to 7.x-3.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.