Initial round of testing on Commons wikis [#1800398]

It's super exciting to see this feature coming together!

Here's some feedback from an initial round of review:

A) We should be checking node_access(), not user_access() when generating the create content link for the browsing widget. That's technically my mistake, since you (correctly) copied my (bad) example from commons_posts. This is corrected in the attached patch.
B) The Panelized wiki page appears to be missing the node content. I believe this is corrected in the attached patch.
C) The panelized wiki page should exist in a separate feature per #1710792: Proposal: Export landing pages separately from underlying components (Views, blocks, etc).
D) The wiki contributors view doesn't show all contributors to a wiki. In its default state, it appears to show none of them. I tested by creating a wiki and editing as another user, and then passing an argument to the view in preview mode.
E) I'm unable to edit the body field as an authenticated user. A quick glance at the markup indicates that the body field is disabled.

Also, I noticed #1800396: Anonymous users should have access to filtered HTML text format for Commons WYSIWYG.

Comment	File	Size	Author
	commons-wikis-r1.patch	5.61 KB	ezra-g

Comments

Comment #1

jpontani commented 3 October 2012 at 14:45

Status:

Active

» Fixed

Committed in 9ecaa18.

Comment #2

ezra-g commented 3 October 2012 at 21:53

Status:

Fixed

» Needs work

Note, my patch only fixes A and B in my testing. The remaining issues need work.

Comment #3

jpontani commented 10 October 2012 at 14:51

D's view not showing all contributors is related to #1754354: Node revisions only displays latest revision. Because not all revision entries were linked correctly to the base entity, the view couldn't grab the revision's author. There is a patch and it has been applied to Views 3 (applied to dev only, no release has been made with the patch).

Comment #4

ezra-g commented 10 October 2012 at 17:36

Thanks! I updated Commons to temporarily use the dev snapshot of Views: #1808896: Switch to dev version of Views module..

Comment #5

ezra-g commented 12 October 2012 at 21:52

I'm still experiencing D with the latest dev of Views.

Looks like there are a few issues with the view, including that we left join on {node} via the node status filter, which is safe to remove since we only ever include this pane in panelized nodes, so node access is already being enforced.

However, in my instal after tweaking the view, l I seem to be having trouble getting Panelizer to pass the right context to the View - I'm getting no results behavior.