Diff module "hijacks" (it's own words) the node form #after_build.

It's not the only module that needs to do this. So, instead of completely hijacking the #after_build, it needs to play nice and share it. The attached patch should fix this.

CommentFileSizeAuthor
diff_after_build.diff1.44 KBDave Cohen

Comments

moonray’s picture

moonray commented
Status: Needs review » Reviewed & tested by the community

Works for me, and fixes issues.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

http://drupal.org/node/153234#comment-657419

*sigh* Moshe "fixed" this bug last June, but only committed the fix to HEAD. I just committed that to DRUPAL-5 and DRUPAL-4-7.

However, I see you've got another hunk in there that cleans up something the earlier patch missed, so I just committed that to HEAD, DRUPAL-5, and DRUPAL-4-7, too.

Thanks!
-Derek

Dave Cohen’s picture

Dave Cohen commented

Be careful with that one line about form['#base'], I think I read that drupal 6 does away with that.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.