As the php version has been updated to 5.3.5 in #1751100: Bump minimum version of php required to 5.3.5 this should be reflected in INSTALL.txt.

CommentFileSizeAuthor
#1 1801032-1.patch677 bytespbz1912

Comments

pbz1912’s picture

pbz1912 commented
Status: Active » Needs review
StatusFileSize
new 1801032-1.patch677 bytes

Patch attached.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

simple review :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1801032-1.patch, failed testing.

pbz1912’s picture

pbz1912 commented

I don't understand why that failed. Is there something wrong with the test?

pbz1912’s picture

pbz1912 commented
Assigned: pbz1912 » Unassigned

removing myself, as unsure how to proceed.

Crell’s picture

Crell commented

pbz1912: The bot sometimes has random failures. Try rerolling the patch and reuploading and see if it takes it a second time. I don't see what could be failing there, either.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review

#1: 1801032-1.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

There we go!

Thanks for this! Committed and pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.