Posted by das-peter on October 3, 2012 at 7:18am
4 followers
Jump to:
| Project: | Webform |
| Version: | 7.x-4.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
Problem/Motivation
On sites with a lot of tokens opening a page with the token replacement list will slow down the browser or even crash it.
Proposed resolution
The token module lately introduced the possibility to show tokens in a dialog which loads the tokens on demand using ajax: #1684984-17: Support opening token browser in a jQuery UI dialog on demand
The change is backward compatible.
Btw. loading the tokens in the dialog is still slow and still could crash the browser but at least it would be on demand :D
Remaining tasks
Review patch
I'm not sure if this plays well with accessibility concerns!
User interface changes
The tree list of tokens is replaced by a link to open a dialog with the token tree list.
API changes
none
| Attachment | Size |
|---|---|
| webform-use-token-dialog-if-available.patch | 320 bytes |
Comments
#1
#2
Patch is simple, applies cleanly, and works as expected. This is a must do.
#3
Recategorizing as a bug.
On a medium-size site, the large volume of tokens is actually causing a fatal memory error (256M exhausted).
Yes, the root cause is an issue in token, but it must be solved in webform.
This is a one-liner, let's get it in.
#4
Thanks guys. Still RTBC, but it's not a bug in Webform. I'll put this in next time I'm going through the Webform queue.