Problem/Motivation

If a component is updated the components translated_strings ($component['extra']['translated_strings']) are lost .
This happens because the used hook hook_webform_component_update() is fired after the update and thus doesn't accept a return value nor a referenced parameter.

Proposed resolution

Use the hook hook_webform_component_presave() instead.

Remaining tasks

Review patch and especially test adding new components.

User interface changes

none

API changes

none

CommentFileSizeAuthor
#1 webform_localization-use-presave-instead-update-hook.patch807 bytesdas-peter
webform_localization-use-presave-instead-update-hook.patch807 bytesdas-peter

Comments

das-peter’s picture

das-peter commented
StatusFileSize
new webform_localization-use-presave-instead-update-hook.patch807 bytes

Sorry for the bunch of duplicates - d.o. just went nuts for a moment.
And here's the lost patch ;)

heliogabal’s picture

heliogabal
Primary language German
Location Berlin
commented

I applied the patch and strings are now kept when updating components. Also adding new components and/or updating them is working. Hope this helps.

GDrupal’s picture

GDrupal commented
Status: Needs review » Fixed

Committed thanks @das-peter

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.