gallery_filter.inc, line 66:

      // Handle special case of n<=1
      if ($params['n'] <= 1) {
        $params['type'] = 'specificItem';
      }

I tried to display a type=randomImage from an album but the album highlight is showed up.

Comments

profix898’s picture

profix898 commented

Hmm. I just looked up if this was introduced by me ;) actually it was there before (gallery_filter.inc, line 94/95)

if ($n_images <= 1)
 $block_type = 'specificItem'; //so it shows something if n=1 and an album is selected

But I agree with you that it doesnt really make sense and I dont understand the comment. Is it safe to remove that check? Or does it have any side effects? I mean was this introduced for purpose or for imperfection of an earlier G2 release?

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented

Nothing could happen.

Why to change the type (for any value of n)? Anyway it has a default value.

profix898’s picture

profix898 commented

OK. I will removed these lines with the next update ... Thanks.

profix898’s picture

profix898 commented
Component: gallery_content.module » Code
profix898’s picture

profix898 commented
Status: Active » Fixed

Bugfix committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)