Add missing type hinting to Action module docblocks

I was pointed to this issue in core mentoring hours.

I added as many type hints as I could following these guidelines, and corrected 1 punctuation error (missing period).

Patch attached.

Reroll.

The only problematic docblock is in EmailAction::_construct(). It's missing the parameter name for $mail_manager.

I say this rather than change it so I can do the review later.

Caught the problems in #4, with a few others.

Re-rolling the patch of @mile23 .

Looking fine

Thanks @yogen.prasad and @deepakaryan1988. Did you carefully review each function to ensure that the typehints were correct in all cases?

These patches should only add missing type hinting, not do any other cleanups. The scope creep of adding other changes do these patches makes them more difficult to review. Long reference as to why: http://webchick.net/please-stop-eating-baby-kittens

+++ b/core/modules/action/src/Plugin/Action/EmailAction.php
@@ -53,13 +53,13 @@ class EmailAction extends ConfigurableActionBase implements ContainerFactoryPlug
-  /** The language manager.
+  /** The language manager service.

This is not the correct docblock format, but it doesn't belong in this patch anyway. :) See above.

Ahh @xjm Thanks for pointing out..
will keep in mind in future!

I re-did the work rather than try to modify #8.

A couple of small out-of-scope items are still in there, because they modify the same file as in-scope issues.

There are instructions for reviewing this issue in the issue summary.

+++ b/core/modules/action/action.api.php
@@ -8,7 +8,7 @@
+ * @param mixed $aid
  *   The action ID.

Don't we know the action ID is a string (or maybe an integer?)

I couldn't find it. The example feeds it to a DB function requiring mixed.

Reroll of #14.

Still not sure about the type of $aid, because it's not documented anywhere.

I suspect its integer

here's the reroll of #17

I think, my patch removes to much things, I'm reviewing it.

Sorry for my previous patch this is the reroll of #17

In IRC w/ @chx we discussed that action.api.php is a) wrong, and b) isn't needed because we already document hook_ENTITY_TYPE_delete().

If action.api.php had any action module specific information it would be worth salvaging but it doesn't.

Let's revert the changes to action.api.php in this patch, and then have a follow-up about deleting the file in another issue.

The follow-up #2663830: Remove action.api.php

Again, please remove the out-of-scope changes. See: https://www.drupal.org/core/scope#merge

(Don't be caught by the fallacy that if it's on the same line or an adjacent line, you should fix it in the same patch to avoid conflicts. Remember that a word diff can be used to review changes within lines, and that an unrelated change on the same line or adjacent line will still be missing accurate information of "why" in the commit log. Instead, create a followup issue.)

Needed a reroll anyway. Removes out of scope changes.

Changing to 8.0.x because that's what we've done on the other similar child issues. The patch applies cleanly to 8.0.x and 8.1.x.

This has been fixed as part of #2721901: Fix Drupal.Commenting.FunctionComment.MissingParamName