Ajax callbacks should be callbacks defined as function or class method

That makes sense...

Hm. Let's add a test for this. I tried grepping through #1792600-29: Refactor field_ui so common behavior for fields and display overview screens are extracted and it was not immediately clear to me how this would work.

I'm a little worried here too about changing AJAX callback to any "is_callable" but not doing this consistently throughout FAPI. But I'm not sure what other similar things we have there, really. I guess submit, process, and validate callbacks? Normally these are done as an array of functions that can be re-ordered.

$form['#submit'] and #validate are already doable as "methods" (entity form controller uses that)
#element_validate, #pre_render, #after_build... are not

I'm a little worried here too about changing AJAX callback to any "is_callable" but not doing this consistently throughout FAPI. But I'm not sure what other similar things we have there, really. I guess submit, process, and validate callbacks? Normally these are done as an array of functions that can be re-ordered.

That doesn't change in any way. But yes, all callbacks in FAPI should get converted to support methods at some point. Yes, we could maybe add a simple test that exposes a method as an ajax callback. Basically we would be testing core PHP functionality with that considering that the patch doesn't change anything apart from the switch to is_callable() :). But then again, it won't hurt... So why not :).

Brb

That should do. I simply converted two of the callbacks to be methods in one of the existing AJAX tests.

Whoops, class name f*ckup :)

#10: 1802072-10.patch queued for re-testing.

Note, as a follow up - #element_validate would be a nice one to convert as well - it would make some field widgets more sane, but let's get this one in first.

Thanks fubhy!

#1805688: Support methods as #element_validate callbacks

Same feedback as #1805688-8: Support methods as #element_validate callbacks; we need to pull that class out to a separate PSR-0 compatible file, and document it.

Yeaah... umh :D

Forgot to add the new file.

Wow, t'is early in the morning :/

Awesome, thanks!

Committed and pushed to 8.x.

We'll need a change notice for this; can likely just be added to the existing FAPI one.

Done.

http://drupal.org/node/1734540

Looks good.

Did I miss something? I don't see the commit!

@webchick I think you might have forgot to push this one. Maybe because the two issues for the patches that needed to be commited are nearly identical :)

The patch doesn't apply anymore. Here is a re-roll. Yah... Or I simply upload an empty file.

Alright, let's get this in! :)

Change notification is done

+++ b/core/modules/system/tests/modules/ajax_forms_test/ajax_forms_test.moduleundefined
@@ -49,7 +53,7 @@ function ajax_forms_test_simple_form($form, &$form_state) {
-      'callback' => 'ajax_forms_test_simple_form_select_callback',
+      'callback' => array($object, 'selectCallback'),

@@ -58,7 +62,7 @@ function ajax_forms_test_simple_form($form, &$form_state) {
-       'callback' => 'ajax_forms_test_simple_form_checkbox_callback',
+       'callback' => array($object, 'checkboxCallback'),

maybe leave one as was before?

Well, why not. To me it is actually not really clear why we need a test for this at all. I mean it really just is a test for is_callable() vs is_function(). We should assume that both work properly :).

Hm. No, it appears I didn't commit it at all. :P Oops. :P Clearly, I need more sleep. :)

REALLY committed and pushed to 8.x this time. :P