Menu tree does not expand when active item is a taxonomy term

What happens if you link to the aliased url?

Yes, I am seeing this too. Installed a fresh D6 from CVS, created a node and a taxonomy term, created a menu item pointing to the term, and created a second menu item pointing to the node, with the previous menu item as its parent. Clicked on the node link and the menu was expanded correctly; clicked on the term link and it was not.

Also, if you have the node as the parent and the taxonomy term as the child, the menu still does not expand on the term page.

I think it's confusing the taxonomy/term/# pages with local tasks. I am not at all sure that I am understanding this correctly. But here is a patch that seems to fix the problem for me.

There is another issue, the menu system should not allow entering aliased links. Nor should the update allow them. I will work on this a bit, please do not commit. And yet, review, whether it solves the problem if you are notusing aliases as you should not.

subscribe

ok - I can reproduce this- and there are a couple ways to approach it.

Attached patch works (be sure to delete existing links before applying the patch and visiting admin/build/modules since the router path is changing). However, this solves it only for this case for taxonomy, and not generally. I think this patch should be applied regardless of whether something like #7 is used, since taxonomy/term is itself never a valid path.

I think code in #7 makes sense - though there could be a few unintended side-effects.

For example - if I append an extra (even meaningless) parameter to a node path: "node/3/x" then as things stand now, the menu will expand properly if there is a link "node/3". With the patch in #7, that is no longer true. However, the link is not highlighted as active in this former case, so there is already a mixed expectation here. The "active" class is set in l() based on the condition $path == $_GET['q']

Attached is a combined #7+#14 patch.

It's RTBC on #14 not #15.

About #7/#15. With $router_item['href'] = implode('/', $path_map); added, if you have a router item without load functions, the href will point to whatever the user has entered. On the other hand, if there is a load function then the only thing that matters is the router item. While #14 is nice and OK I would like to see lot more explanation from jmorahan or pwolanin or anyone about the possible consequences here -- I will also think about it but I am not convinced we want this change so late.

Also note that meanwhile we got

  $item = &$form_state['values']['menu'];
  $normal_path = drupal_get_normal_path($item['link_path']);
  if ($item['link_path'] != $normal_path) {
    drupal_set_message(t('The menu system stores system paths only, but will use the URL alias for display. %link_path has been stored as %normal_path', array('%link_path' => $item['link_path'], '%normal_path' => $normal_path)));
    $item['link_path'] = $normal_path;
  }

so the aliasing is covered.

#14 seems to be simple and correct for the case in hand, so committed!

Demoting to normal and for review for the other more generic modifications, leaving room to discuss them.

no patch here

any more substantial changes are not for 6.x

Just experienced this on a project I am working on.

Is running the lates 6.x with the following modules installed:
CCK (+links), Conditions, Aggregator, Comment, Contact, Content translation, Database logging, Forum, Help, Locale, Menu, Path, PHP Filter, Ping, Poll, Search, Statistics, Syslog, Taxonomy, Tracker, Trigger, Update Status, Upload, Devel, Advanced Help, Pathauto, TinyMCE, Token, Token Actions, Activemenu, Collapsiblock, Javascript tools, Tabs, Views, Fivestar, Voting API

that should be all of them.

The error still happens when I try to link to the super taxonomy term and then have a "submenu" branch of it's sub terms.

lslinnet - could you confirm whether you still get the error with all contributed modules disabled?

Marking this back to closed - looks like any remaining issues may be dealt with at: http://drupal.org/node/251868