Closed (fixed)
Project:
Dreditor (moved)
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2012 at 17:50 UTC
Updated:
27 Aug 2013 at 15:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
yesct commentedComment #2
attiks commentedjust testing the patch
Comment #3
attiks commentedComment #4
attiks commentedComment #5
attiks commentedComment #6
attiks commentedlink back added
uses the issue summary
Comment #7
gábor hojtsyThis is a wonderful suggestion IMHO :) Good for managing followups to big issues.
Is there some info that is not the title in the page? Most project machine names do not equal their name :/
Comment #8
attiks commented#7 fixed, thanks for the tip
Comment #9
yesct commentedThe patch from #6 works great.
To test it (or use it)
git clone --recursive --branch master http://git.drupal.org/project/dreditor.git
cd dreditor
curl -O http://drupal.org/files/i1803622-6.patch
git checkout -b i1803622-6
git apply i1803622-6.patch
then drag that dreditor to the chrome settings (like the dreditor install instructions)
the button
the new issue
Comment #10
yesct commentedcode looks good too.
the patch has some white space changes, but the end of the patch with the new functionality is straightforward.
Comment #11
attiks commentedfor easy testing a patched version
Comment #12
yesct commentedthis has been working really well for me.
sometimes it wont clone (like for this issue: #1903888: Add 'cancellation' check when results reported to qa.d.o) maybe something with a character in the project name?
happy to keep using as is, just adding that info.
Comment #13
larowlanWorks as advertised!
Comment #14
yesct commentedthis issue doesn't clone, also has strange project name #493074: Back-link to the commit as a comment on the related issue.
Comment #15
attiks commented#12 + #14 the page is taking too long to load, in the script is a timeout of 3 seconds, attached a new version but needs testing in different browsers.
Comment #16
yesct commentedI've been using the new version and its working well. No more blanks . Time out issue might be fixed. ( I didn't try those same issues though).
Comment #17
kristen polWorks great! Thanks :) I won't mark RTBC because there is a "needs accessibility review" tag. But... would be awesome if this got in asap.
Comment #18
kristen polOk... it would be *great* to have the tags *not* be collapsed because we won't often want to change these and we forget because they are collapsed ;) 3 of us had this issue so far in the sprint today. Thanks!
Comment #19
attiks commentedShould work
Comment #20
kristen polYeah! Tested and works great :) Thanks!
Comment #21
yesct commented1.
need a period at end of sentence.
2.
not a sentence.
I suggest:
// Open a new window.
I found someone at the sprint to make a new patch. Patch coming.
Comment #22
jan-e commentedNew patch and interdiff with the suggested changes by YesCT in #21
Comment #23
attiks commented#22 Thanks, back to RTBC
Comment #24
yesct commentedI've been using this and found that I often forget to change the title.
An empty title would be better.
Comment #25
attiks commented#24 I mostly just change the title, maybe we should look into adding settings to dreditor, but I rather do this in a separate issue.
If more people wants the title blanked out, I don't mind changing it.
Comment #26
klonosPerhaps prepend "[Follow-up]: " to the title by default
Comment #27
kristen polI think either empty or #26 suggestion for title is fine.
Comment #28
yesct commentedLet's go with empty and open a follow-up for personalize settings.
Comment #29
markhalliwellRemoved the prefilled title. Made the page scroll to the fields by using url hash. Focused on title. Removed issue summary since there will be a button for that and is not always needed. Let me know if we need to work on this more or if it's RTBC.
Comment #30
yesct commenteddoes the issue summary template button replace the issue summary, or get appended on the end of it? hmm. I should check.
Comment #31
markhalliwellNew position of button
Comment #32
yesct commentedI like this and it works well.

code looks good at quick glance.
If we need another review, please say what we need, otherwise.... rtbc.
Comment #33
yannickooHere you are using a protocol relative URL ...
... and here we have HTTPS only, is there are reason for that? Just asking :)
Comment #34
star-szrThanks for taking a look @yannickoo. The RegEx there actually makes the s in https optional by adding a question mark after it.
Making the docblock for this behavior a bit clearer and (hopefully) fixing up indentation - no functional changes.
Tested and working well on Chrome and Firefox.
Comment #35
yannickooWe could use HTTPS in every place because drupal.org redirects you automatically to the HTTPS version.
Comment #36
attiks commented#35 We do now, but nobody knows what the future will bring, although I think this will not change, better to support all protocols.
Screenshot looks neat
Comment #37
markhalliwellI'm happy with #32 and #34.
Thanks everyone! Committed 89418ac :)