Download & Extend
Webform » Issues

Undefined variable: account in webform_set_breadcrumb()

Posted by eltermann on October 4, 2012 at 8:59pm
Project:Webform
Version:7.x-4.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:eltermann
Status:reviewed & tested by the community

Issue Summary

Just found this user_access('access own webform results', $account) with $account not defined.

Patch attached.

AttachmentSize
0001-Removing-undefined-and-unnecessary-variable.patch927 bytes
Login or register to post comments

Comments

#1

Posted by bxtaylor on October 9, 2012 at 4:30am
Status:needs review» reviewed & tested by the community

Patch applies cleanly.

The breadcrumb still functions properly for users with the 'access own webform results' permission.

#2

Posted by qinshuguo on October 25, 2012 at 2:50am

patch solves the problem

#3

Posted by Shawn DeArmond on January 9, 2013 at 11:28pm

Confirmed again. +1

#4

Posted by pjcdawkins on February 21, 2013 at 12:40pm
Status:reviewed & tested by the community» needs review

Can we also fix another problem with the same function, involving cases where $breadcrumb starts off empty? Webform was adding an empty breadcrumb item.

AttachmentSize
webform-1803808-4.patch 983 bytes

#5

Posted by froboy on February 21, 2013 at 5:31pm

Worked for me too.

#6

Posted by Shawn DeArmond on February 22, 2013 at 9:15pm
Status:needs review» reviewed & tested by the community

@pjcdawkins, that is out of scope for this particular issue. Please file a different issue.

OP's patch is RTBC.

#7

Posted by Jerenus on May 17, 2013 at 9:37am

work for me.