Right now this value looks like it works independent of the main enabled settings. We should only show this when XHProf is currently enabled (similar to the profiling interval).

CommentFileSizeAuthor
#3 XHProf-admin_pages_setting_conditional-1803858-3.patch1.08 KBerikwebb
#1 XHProf-admin_pages_setting_conditional-1803858-1.patch1.04 KBerikwebb

Comments

erikwebb’s picture

erikwebb commented
Status: Active » Needs review
StatusFileSize
new XHProf-admin_pages_setting_conditional-1803858-1.patch1.04 KB
jrbeeman’s picture

jrbeeman
he/him
Primary language English
Location Arizona, USA
commented
Status: Needs review » Reviewed & tested by the community

Verified that this fixes the issue. UX is a little funky, though. I'd suggest maybe turning the whole settings element into a fieldset, but that could be handled separately.

erikwebb’s picture

erikwebb commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new XHProf-admin_pages_setting_conditional-1803858-3.patch1.08 KB

How about this one?

msonnabaum’s picture

msonnabaum commented
Status: Needs review » Fixed

Just committed this patch with some changes. I put everything in the dependent fieldset since none of it is relevant without the enabled setting.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.