Needs review
Project:
Drupal Commerce Extra Price Formatters
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Oct 2012 at 07:24 UTC
Updated:
15 Dec 2014 at 11:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
idflood commentedHere is a first patch, it simply use the t() function.
Comment #2
idflood commentedComment #3
ikos commentedHi,
Thanks for reporting.
I initially didn't think this patch was necessary as you can set your own text for prefix and suffix.
However on reflection I can see that for a multilingual site you'd want to have different values.
Testing the patch now.
kind regards
Richard
Comment #4
ikos commentedOK I couldn't get the patch to work so I changed the approach a little - please test this one and see if it works.
Comment #5
joerch commentedHi!
I would like to test the patch but I have only basic skills in programming and I never used git.
Is there an other possibility to get a updated module file?
//joerch
Comment #6
cosmin-hm commentedHi,
After applying the v2 patch it renders as:
<span class="price_prefix"><p>From</p></span>... as seen at http://euphone.hodis.ro/ro/product-category/smartphones
-----
joerch, check http://www.lightrains.com/blog/apply-patches-drupal-modules-files, it's the easiest way to apply patches that I found.
Comment #7
cosmin-hm commentedWell, I'm not a coder so I can't pinpoint this, but when I switched from "plain text" to "PHP code" in the field display management, the p tag disappeared.
I'm still no sure where I should translate the prefix, because refreshing the strings brought nothing new in Translate.
Comment #8
akalam commentedNew patch to translate "From" prefix
Comment #9
dxxPatch from #8 working good but allow the translation with HTML into field, I'm not sure whether this is a desired operation?
Comment #10
hunlaprovo commentedYou do not have to change anything, but in
https://drupalcommerce.org/questions/7247/price-prefix-product-list-page