Update TinyMCE for 6.x and clean up any code that is not to the Drupal specification
Beau Gunderson - October 3, 2007 - 06:51
| Project: | TinyMCE WYSIWYG Editor |
| Version: | 6.x-1.1-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
I wanted to use TinyMCE in a 6.x installation and so started creating a patch to do so.
The patch is attached and gets us almost all of the way there--the module installs and you can add and edit profiles. You may have to 'touch tinymce.schema' in your modules/tinymce directory to get the patch to apply cleanly as this file did not exist in the previous version. This is a patch against 5.x-1.9.
It does not, however, currently show up on textareas on the node/user/etc. edit pages yet. I may have time in the next week to investigate further.
I used the "Coder" module to ensure that the code was in compliance with the Drupal spec.
| Attachment | Size |
|---|---|
| tinymce.10.2.patch | 15.27 KB |
#1
subscribed
#2
subscribe
#3
With Drupal 6 RC1 coming this week, getting TinyMCE updated for 6 is a top priority... unfortunately one of many. I'm starting a thread about this at http://groups.drupal.org/tinymce-development
#4
subscribe
#5
subscribe
#6
I also tried to do some porting. The results:
However, there are some problems.
#7
subscribe
#8
subscribe
#9
bumping with the recent release of D6...
I have a little time and could do testing...
#10
So we have two patches. Do we apply the first one and then the second? Someone needs to coordinate these efforts.
#11
Also, I just found a bug in the tarball that was uploaded. So where is the best way to submit this patch?
I think whoever is in charge of this module needs to start a drupal6 branch and post it here so it can be worked on collaboratively.
#12
subscribe
#13
How do I apply the patch without command line access?
#14
subscribing
#15
#16
That's the reason stopping me from upgrade to 6.x
#17
subscribing
#18
subscribed.
#19
subscribed
#20
subscribe
#21
Subscribed.
#22
subscribe
#23
subscribe
#24
is there already a view about the date that the module will be ported to drupal 6.1?
#25
Aaargh on all the subscribes :P
Please do no set to critical -- this is not a bug, it's a feature. We have a couple of patches, please test and provide feedback.
I see multiple maintainers listed but looks like folks are out of time. I will have my team do some testing and see if we have resources to work on a port.
#26
subscribe
#27
subscribing
#28
subscribe
Thanks Boris for looking into the further development of the patches.
#29
Subscribe
#30
Very important update
bump
#31
Hi.
how do you apply the patch?
thx
#32
Read about on the handbook pages http://drupal.org/patch/apply
#33
Subscribe
#34
Hi. I've ported TinyMCE to Drupal 6. It took me over two days to fix it, but it does work now.
You can download it at http://akie.nl/2008/03/16/tinymce-for-drupal-6/
Basic functionality works for both TinyMCE 2 and TinyMCE 3. TinyMCE 2 is preferred though, since the DrupalBreak-button doesn't work on TinyMCE 3. Can someone please take a look at that? If we fix that, we'll finally have a decent editor for Drupal 6.
Anyway, good luck with this. Please leave a comment at the link above if you like it or dislike it.
Hope this helps,
Akie
#35
bump-a-luff-a-gus-!!
#36
Here are my results after a quick test of Akie's code (I tested this in Drupal 6.1 using TinyMCE 2.1.3):
- Getting this warning message on the TinyMCE error page when creating a new profile (doesn't occur when editing a profile).
warning: Invalid argument supplied for foreach() in /var/www/local.sandbox.com/htdocs/drupal-6.1/includes/form.inc on line 1181.
- The default state option doesn't seem to have any weight on whether TinyMCE is run. Everytime I create a new page, TinyMCE is shown without an option to disable it.
- Other than those two issues, everything I was able to test in the matter of 15 minutes has worked fine and I will most likely use this for one of my clients (they won't need to disable the WYSIWYG).
Thanks for putting this together and hope those issues can get figured out soon!
#37
Subscribe
#38
subscribe
#39
subscribing
#40
here is another patch this one works fine but requires some cleanup to split code into multiple files and either remove or work with drupal's teaser splitter.
IMO it needs a rewrite, the code is a mess.
#41
subscribing
#42
I have installed TinyMCE for Drupal 6.x as described by Akie.
After enabling the module and going to Administer>Site configuration>TinyMCE>Add new profile, I get the message:
warning: Invalid argument supplied for foreach() in \drupal\includes\form.inc on line 1181.
which has been described before by klamping.
Is this new patch file from alaa for that release or is this another patch file?
Should I apply this patch or just go ahead and use the release as it is?
Thanks for the help.
Izzy
#43
izmeez the patch I posted on #40 is a separate patch and has nothing to do with Akie's module.
#44
it wont work for me.
Including the project notes etc...
its there under profiles but it wont show.. it tells me that the tiectory is missing.. but its there.
#45
subscribe
#46
I've created a release from Akie's updates and installed the release as a demo at http://tinymce-dev.sidewalktheory.com/. Please submit new issues and patches for the 6.x version. Closing this thread.
#47
alaa thanks for the clarification. I came to that realization my self as I saw the link for the akie release also has discussion further down on that web page.
Izzy