PHP notices when using print_join_page_counter [#1804436]

The constructor in the views handler for page counter is not happy when called without arguments.

Warning: Missing argument 1 for print_join_page_counter::construct(), called in /Users/ckj/Sites/inf/d7/sites/all/modules/views/includes/handlers.inc on line 120 and defined i print_join_page_counter->construct() (linje 14 af /Users/ckj/Sites/inf/d7/sites/all/modules/print/print_join_page_counter.inc).
Warning: Missing argument 2 for print_join_page_counter::construct(), called in /Users/ckj/Sites/inf/d7/sites/all/modules/views/includes/handlers.inc on line 120 and defined i print_join_page_counter->construct() (linje 14 af /Users/ckj/Sites/inf/d7/sites/all/modules/print/print_join_page_counter.inc).
Warning: Missing argument 3 for print_join_page_counter::construct(), called in /Users/ckj/Sites/inf/d7/sites/all/modules/views/includes/handlers.inc on line 120 and defined i print_join_page_counter->construct() (linje 14 af /Users/ckj/Sites/inf/d7/sites/all/modules/print/print_join_page_counter.inc).
Warning: Missing argument 4 for print_join_page_counter::construct(), called in

Views will sometimes call without arguments and that works well, so the constructor needs to have default arguments. Made a patch that does that.

Comment	File	Size	Author
	default_arguments_constructor.patch	767 bytes	naxoc

Comments

Comment #1

naxoc commented 5 October 2012 at 11:44

Also posted a patch in the views queue (where the bug kinda comes from) to fix the documentation. #1804448: Code from documentation is causing PHP notices