Download & Extend
Link checker » Issues

Lots of warnings when comment/block modules are not installed

Posted by mathieu on October 5, 2012 at 6:45pm
Project:Link checker
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I have this D6 site (with i18n, without comments) and I was getting a lot of warning like this (once per node or link) :

User warning: Table web.node_comment_statistics doesn't exist query: SELECT last_comment_timestamp, last_comment_name, comment_count FROM node_comment_statistics WHERE nid = 19 in _db_query() (line 169 of /..../drupal/includes/database.mysqli.inc).
User warning: Table web.comments doesn't exist query: SELECT COUNT(*) FROM comments c WHERE c.nid = 19 in _db_query() (line 169 of /..../drupal/includes/database.mysqli.inc).
User warning: Table web.comments doesn't exist query: SELECT c.cid as cid, c.pid, c.nid, c.subject, c.comment, c.format, c.timestamp, c.name, c.mail, c.homepage, u.uid, u.name AS registered_name, u.signature, u.signature_format, u.picture, u.data, c.thread, c.status FROM comments c INNER JOIN users u ON c.uid = u.uid WHERE c.nid = 19 ORDER BY c.thread DESC LIMIT 0, 50 in _db_query() (line 169 of /..../drupal/includes/database.mysqli.inc).

Here's a patch against latest 6.x-dev that fixes it.

AttachmentSizeStatusTest resultOperations
no_comments.patch658 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch no_comments.patch. Unable to apply patch. See the log in the details link for more information.View details
Login or register to post comments

Comments

#1

Posted by System Message on October 5, 2012 at 7:09pm
Status:needs review» needs work

The last submitted patch, no_comments.patch, failed testing.

#2

Posted by hass on December 5, 2012 at 12:26am

This patch is not correct. In D7 we are using hook_modules_disable(). In D6 we may use http://api.drupal.org/api/drupal/developer%21hooks%21install.php/function/hook_disable/6 and set the linkchecker_scan_comments variable to 0. See linkchecker_modules_disabled() for details.

#3

Posted by hass on December 5, 2012 at 12:48am
Version:6.x-2.x-dev» 7.x-1.x-dev

Damn, you are right. We also need to do this for blocks in D7.

#4

Posted by hass on December 6, 2012 at 12:31am
Title:Lots of warnings when comment module is disabled and its table is not in database» Lots of warnings when comment/block modules are not installed

#5

Posted by hass on December 6, 2012 at 12:46am
Status:needs work» needs review

Patch for review

AttachmentSizeStatusTest resultOperations
linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch3.11 KBIdleFAILED: [[SimpleTest]]: [MySQL] 149 pass(es), 2 fail(s), and 0 exception(s).View details

#6

Posted by hass on December 6, 2012 at 12:46am

#7

Posted by System Message on December 6, 2012 at 12:47am
Status:needs review» needs work

The last submitted patch, linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch, failed testing.

#8

Posted by hass on December 6, 2012 at 1:22am
Status:needs work» needs review

#5: linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch queued for re-testing.

#9

Posted by System Message on December 6, 2012 at 1:27am
Status:needs review» needs work

The last submitted patch, linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch, failed testing.

#10

Posted by hass on December 6, 2012 at 1:31am
Status:needs work» needs review

#5: linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch queued for re-testing.

#11

Posted by System Message on December 6, 2012 at 1:32am
Status:needs review» needs work

The last submitted patch, linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch, failed testing.

#12

Posted by hass on December 6, 2012 at 1:41am
Status:needs work» needs review

Cannot repro test failures locally.

AttachmentSizeStatusTest resultOperations
linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch3.11 KBIdleFAILED: [[SimpleTest]]: [MySQL] 149 pass(es), 2 fail(s), and 0 exception(s).View details

#13

Posted by System Message on December 6, 2012 at 1:42am
Status:needs review» needs work

The last submitted patch, linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed.patch, failed testing.

#14

Posted by hass on December 6, 2012 at 11:14am
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed2.patch3.11 KBIdlePASSED: [[SimpleTest]]: [MySQL] 151 pass(es).View details

#15

Posted by hass on December 6, 2012 at 11:35am
Status:needs review» patch (to be ported)

D7: http://drupalcode.org/project/linkchecker.git/commit/57c26ca && http://drupalcode.org/project/linkchecker.git/commit/7ee50f8

#16

Posted by hass on December 6, 2012 at 11:49am
Version:7.x-1.x-dev» 6.x-2.x-dev
Status:patch (to be ported)» needs review

D6 Patch attached

AttachmentSizeStatusTest resultOperations
linkchecker_1804842+Lots+of+warnings+when+comment_block+modules+are+not+installed-D6.patch2.18 KBIdlePASSED: [[SimpleTest]]: [MySQL] 97 pass(es).View details

#17

Posted by hass on December 6, 2012 at 12:00pm
Status:needs review» fixed

D6: http://drupalcode.org/project/linkchecker.git/commit/8f46aef

#18

Posted by System Message on December 20, 2012 at 12:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.