Tabs sort order incorrect

Try assigning explicit #weight attributes to each tab page.

I'm not sure why the uasort is reordering items that don't have an explicit weight set. A problem with how I implemented it?

Reopening and marking http://drupal.org/node/172848 a duplicate.

Looking for ideas on why uasort is reordering. Here are the relevant lines in tabs.module:

  // Sort the elements by weight.
  uasort($element, "_element_sort");

And here is _element_sort() from common.inc:

/**
 * Function used by uasort in drupal_render() to sort structured arrays
 * by weight.
 */
function _element_sort($a, $b) {
  $a_weight = (is_array($a) && isset($a['#weight'])) ? $a['#weight'] : 0;
  $b_weight = (is_array($b) && isset($b['#weight'])) ? $b['#weight'] : 0;
  if ($a_weight == $b_weight) {
    return 0;
  }
  return ($a_weight < $b_weight) ? -1 : 1;
}

Removing the sort fixed the issue for me as most applications of the jsTools Tabs module don't implement #weight and use their own sorting methods. Panels Tabs, for example, just puts the items in the order in which they should be displayed.

  // Sort the elements by weight.
  //uasort($element, "_element_sort");

Could you try this in your situation? If it works for other applications, I'll make a patch for it.

This code only applies to using the Tab module inside of JStools (not Panels Tab). This is how I fixed the issue:

  $form['toptabs']['secondtabs'] = array(
    '#type' => 'tabpage',
    '#title' => t('Tab Title'),
    '#content' => t('A tab description.'),
    '#weight' => '-3',
  );
  $form['toptabs']['secondtabs']['tabset1'] = array(
    '#type' => 'tabset',
  );
// Tab A
  $form['toptabs']['secondtabs']['tabset1']['tab1'] = array(
    '#type' => 'tabpage',
    '#title' => t('Second Title A'),
    '#content' => t('Second Title A Content'),
    '#weight' => '-8',
  );
// Tab B
  $form['toptabs']['secondtabs']['tabset1']['tab2'] = array(
    '#type' => 'tabpage',
    '#title' => t('Second Title B'),
    '#content' => t('Second Title B Content'),
    '#weight' => '-6',
  );

I set the weight for both the first and second set of tabs.

I implemented support for explicit #weight because in some cases we need it. This follows what we do with other form elements. The challenge is to identify the bug in the implementation, as I noted above (#5).

Commenting out uasort will break routines that rely on it. Try this:

foreach ($element AS $value)
if (array_key_exists($value, '#weight')) {
uasort($element, "_element_sort");
break;
}

This will call the sort routine only if a '#weight' tag is found in the right place. NOTE: there is a '#weight' tag at the root level of the array otherwise we could do this without a loop.

Commenting out uasort will break routines that rely on it. Try this:

  foreach ($element AS $value)
		if (array_key_exists($value, '#weight')) {
			uasort($element, "_element_sort");
			break;
	  }

This will call the sort routine only if a '#weight' tag is found in the right place. NOTE: there is a '#weight' tag at the root level of the array otherwise we could do this without a loop.

Found I had to add a little more checking after installing more modules. My guess is that some of them aren't quite as stringent as they should be on what they pass. In any case, here is the code updated:

  // Sort the elements by weight.
  foreach ($element AS $value)
    if (is_array($value) && array_key_exists('#weight', $value)) {
      uasort($element, "_element_sort");
      break;
    }

Thanks for the troubleshooting. I've applied an attempted fix to HEAD and the DRUPAL_5 branch, which is simply to assign the elements a default #weight value in the hook_elements() implementation. Untested. Anyone want to test and mark this issue accordingly?

Although I haven't tested it yet, Wim added the #weight to Panels Tabs here and here. It should be good now.

The issue was that uasort() changes the order of array elements even if there is no reason to reorder them.

I've added code to give all unweighted tabs an explicit incremental weight.