Fatal error: Class 'Drupal\Core\Template\ArrayIterator' not found in core/lib/Drupal/Core/Template/Attribute.php

So we need a test for this! Not sure it's critical

Found as part of twig engine conversion.

I am not sure this really needs a test and how to test this. Any ideas?

I think it is bad practice to use a class inside of a namespace and not add a use statement.

So I'd rather say this is a regression of the Attribute patch as calling new Attribute() from a different namespace can error out with fatal error.

In this case a new Attribute() added to template_preprocess_table lead to fatal error of:

[07-Oct-2012 17:46:33] PHP Fatal error:  Class 'Drupal\Core\Template\ArrayIterator' not found in /Users/fabian/Sites/twig/drupal_8_theme_and_twig_sprint/core/lib/Drupal/Core/Template/Attribute.php on line 132

Unassign again due to x-post.

Found another one. Setting status to needs review for the bot.

So not one test in core actually uses these iterators?

According to the new guideline, global namespace objects should be referenced using \ArrayIterator, without explicit use statements.

Here are two patches that provide a test and bring these two files up to standards in light of #8. The first one (test only) should fail, the second one should pass.

Whoops. Set status.

Looks good to me.

Awesome, thanks for the fix and for the tests.

Committed and pushed to 8.x.