geoJSON data from URL breaks openlayers map [#1805844]

Posted by Mac_Weber on October 7, 2012 at 6:22pm

3 followers

Issue Summary

Problem/Motivation

Problem Behavior

Using geoJSON Layer Type works fine if giving arbitrary GeoJSON Data on (/admin/structure/openlayers/layers/list/).

However, if using the URL option it is breaking the openlayers map. If it is set up to use URL (without any GeoJSON Data) and this layer is enabled then the map is not displayed at all.

Technical Explanation

This issue is caused by how the geoJSON data is being loaded when the BBOX option is disabled.
If the BBOX option is enabled it loads correctly because it is being loaded from another part of the code.

In addition, the logic used to choose the BBOX strategy could share some common code with other strategies as well.

Modules versions

openlayers 7.x-2.0-beta1+83-dev
views_geojson 7.x-1.0-alpha2

Proposed resolution

Change how the geoJSON URL is loaded, making it similar to the code used for BBOX strategy.
Share code between BBOX, Fixed , and other possible strategies. Only the strategy type must be changed, all the remaining loading code is the same.

edit: moved this issue to openlayers module as the patch is against one of its files.
edit[2]: added better issue description

Comments

#1

Posted by Mac_Weber on October 8, 2012 at 3:45am

Project:	Views GeoJSON	» OpenLayers
Version:	7.x-1.0-alpha2	» 7.x-3.x-dev

Moving to openlayers module.

#2

Posted by Mac_Weber on October 8, 2012 at 4:00am

Including patch to fix this issue.

BBOX filter is not working, see #1806048: BBOX filter not working

Attachment	Size	Status	Test result	Operations
openlayers-fix_getting_geoJSON_layer_from_URL-1805844-2.patch	2.32 KB	Idle	PASSED: [[SimpleTest]]: [MySQL] 238 pass(es).	View details

#3

Posted by Mac_Weber on October 8, 2012 at 4:00am

Status:

active

» needs review

#4

Posted by System Message on October 8, 2012 at 4:07am

Status:

needs review

» needs work

The last submitted patch, openlayers-fix_getting_geoJSON_layer_from_URL-1805844-2.patch, failed testing.

#5

Posted by Mac_Weber on October 8, 2012 at 4:21am

Status:

needs work

» needs review

#2: openlayers-fix_getting_geoJSON_layer_from_URL-1805844-2.patch queued for re-testing.

#6

Posted by System Message on October 8, 2012 at 4:25am

Status:

needs review

» needs work

The last submitted patch, openlayers-fix_getting_geoJSON_layer_from_URL-1805844-2.patch, failed testing.

#7

Posted by Mac_Weber on October 8, 2012 at 4:41am

Version:	7.x-3.x-dev	» 7.x-2.x-dev
Status:	needs work	» needs review

#8

Posted by Mac_Weber on October 8, 2012 at 4:41am

#2: openlayers-fix_getting_geoJSON_layer_from_URL-1805844-2.patch queued for re-testing.

#9

Posted by Mac_Weber on October 10, 2012 at 9:18pm

Changed OpenLayers documentation links to version 2.12, as suggested by zzolo

Attachment	Size	Status	Test result	Operations
openlayers-fix_getting_geoJSON_layer_from_URL-1805844-9.patch	2.32 KB	Idle	PASSED: [[SimpleTest]]: [MySQL] 238 pass(es).	View details

#10

Posted by Pol on December 26, 2012 at 4:22pm

Status:

needs review

» needs work

+++ b/plugins/layer_types/openlayers_layer_type_geojson.jsundefined
@@ -39,33 +39,28 @@ Drupal.openlayers.layer.geojson = function(title, map, options) {
-    var layer = new OpenLayers.Layer.Vector(title, options);
-
-    // Use an AJAX like call to get data from URL
-    OpenLayers.loadURL(options.url, {}, null, function (response) {
-      var format = new OpenLayers.Format.GeoJSON(geojson_options);
-      var features = format.read(response.responseText);
-      // Add features, if needed
-      if (features) {
-        layer.addFeatures(features);
-        layer.events.triggerEvent('loadend');
-      }
-    });

Are you sure about removing this part ?