Convert theme_select to select.twig

Your preprocess function should read:

function template_preprocess_select(&$variables) {
...
}

Variables have to be passed by reference, as indicated by the ampersand. This is why the variables being set in your preprocess function are not being rendered in your twig template.

+++ b/core/includes/form.incundefined
@@ -2672,6 +2672,25 @@ function theme_select($variables) {
+  if (isset($element['#attributes'])) {
+    $variables['attributes'] = new Attribute($element['#attributes']);
+  }

$variables['attributes'] should _always_ be set.

So start with:

$variables['attributes'] = new Attribute(array());
if (isset(..

Documentation feedback:

+ * Returns HTML for a select form element.
+ *
+ * Variables
+ *   - attributes: an array of attributes including 'class', 'id', and 'width'.
+ *   - options: the HTML for the list of select options.
+ *

Replace "Returns HTML" with "Default theme implementation". (I've just clarified this in the conversion instructions doc).

Replace "Variables" with "Available variables:"

Outdent the variables themselves (eg "- attributes") so the dash lines up one space away from the asterisk (*).

due to #10 need work

diff --git a/core/themes/stark/templates/form.inc/select.twig b/core/themes/stark/templates/form.inc/select.twig
new file mode 100644
index 0000000..15b0246
--- /dev/null
+++ b/core/themes/stark/templates/form.inc/select.twig

This is more for my own understanding than a critique of the work, but assuming this is going to be committed to the front-end branch, shouldn't this be select.html.twig per the current instructions? I know the theme engine branch is using something else, but I'm not clear on what the current plan/process is for when these two things will be merged to work together.

steve, youre going to hate me, for not getting all this feedback in a single post. Sorry :(

<code>
+ * Preprocess select form element variables.
+ *
+ * @param $variables
+ *   An associative array containing:
+ *   - element: An associative array containing the properties of the element.
+ *     Properties used: #title, #value, #options, #description, #extra,
+ *     #multiple, #required, #name, #attributes, #size.
+ */

Are we supposed to include @see twig-template.html.twig in the preprocess functions we add? Not sure if this is in the conversion doc or not, but seems to make sense.

#15 looks good
#16 as for me - it is good practice for documentation here

#1806066-15: Convert theme_select to select.twig commited/push to front-end

Thanks!

status