Download & Extend
Issues

Test whether Views' form fields are labeled

Posted by xjm on October 8, 2012 at 11:59am
Project:Drupal core
Version:8.x-dev
Component:views_ui.module
Category:task
Priority:normal
Assigned:Unassigned
Status:active
Issue tags:accessibility, Needs manual testing, Novice, VDC

Issue Summary

Part of meta issues #1805996: [META] Views in Drupal Core and #1802678: [META] Views: accessibility review.

Steps

  1. Test this issue using 8.x HEAD:
    git clone --recursive --branch 8.x http://git.drupal.org/project/drupal.git
  2. Enable Views and Views UI.
  3. Test each screen of the Views UI, including: the administrative view listing, the view creation wizard, the advanced administrative interface, and modal dialogs.
  4. Every form field needs a correctly associated label. Run a test using the WAVE Toolbar and identify any incorrect labels. (More about automated checking, More on #title and #title_display)
  5. Report any problems in this issue.

Reference: core accessibility gate.

Login or register to post comments

Comments

#1

Posted by xjm on October 8, 2012 at 6:09pm
Project:Drupal core» VDC
Version:8.x-dev» <none>
Component:other» Code

#2

Posted by xjm on October 22, 2012 at 9:12pm
Project:VDC» Drupal core
Version:<none>» 8.x-dev
Component:Code» views_ui.module

#3

Posted by irunflower on October 24, 2012 at 4:53pm

There were no errors thrown by WAVE. I double checked the form field labels to make sure they made sense.

I am not sure if there is a list of correct "field form labels" - if there is, please post and I will double check them.

#4

Posted by dawehner on October 24, 2012 at 10:12pm

I'm wondering which modals did you checked. Some potential problematic pages could be:

  • add/edit a field/filter/sort/contextual filter/relationship
  • reorder fields/filters ...

#5

Posted by xjm on October 25, 2012 at 1:09pm

Agreed, it would be good to document here explicitly each path/interaction that was tested and what the results were. A (cropped) screenshot of the results would help too.

#6

Posted by falcon03 on October 25, 2012 at 9:04pm

@XJM: yes, Yesterday I was thinking about a problem with the Views accessibility review: the Views UI is really complex and we should ensure that everything is tested and, if possible, that two people won't loose their time testing the same thing (at least until the accessibility review is completed).

So I was wondering what the best method to track progress about this review was... And I thought that:

  1. We could create a wiki page (maybe on the accessibility group) to serve as a report on what needs to be done and what has been already done;
  2. Or start a new issue for every bug found and edit the summary of this issue to let others know what has been tested

Any thoughts?

BTW, I plan to spend some time on this issue next weekend...

#7

Posted by xjm on October 25, 2012 at 9:41pm

@falcon03, Well, I'd prefer to track progress using these five issues (one for each point of the core accessibility gate). I think we can start by having everyone document exactly what they've tested, as is already happening in #1806022: Views' text color does not have sufficient contrast and #1806308: Views' Javascript is not keyboard-usable. We've already identified critical bugs under both those issues, so we'll want to resolve those as soon as possible and then test again, perhaps with a more detailed plan, once the critical bugs are resolved.

nobody click here