This patch provides for the following:

  • Allows for use of View level substitutions in the X/Y axis as well as title field placed on the display
  • Substitutions are generated through the use of arguments presented to the view

This also takes into account the X and Y axis labels added in #1784750: Configuration options for views integration

Example usage: Add %1 to a field in order to get the current argument's title, see screenshot for usage

CommentFileSizeAuthor
#3 google_chart_tools-allowsubs-1806522-3.patch1.81 KBkonforti
#2 google_chart_tools-allowsubs-1806522-2.patch2.03 KBbtopro
google_chart_tools-allowsubs.patch1.31 KBbtopro
Example usage to pull title from argument63.42 KBbtopro

Comments

konforti’s picture

konforti commented

Cool, very nice feature.
When the substitutions are not set (there no contextual-filter set in the view), the '%1' is printing to screen, and it's Ok.
But if the contextual-filter is set but it's empty (no argument supplied), the '%1' should not be printing to screen. its should be substitute it to an empty string or so.

If you can update the description of these fields with the new ability it will be great too.

Thanks.

btopro’s picture

btopro commented
StatusFileSize
new google_chart_tools-allowsubs-1806522-2.patch2.03 KB

Run the patch included in the OP then run this one. If an argument is included but the substitution isn't set then this will remove them correctly

konforti’s picture

konforti commented
StatusFileSize
new google_chart_tools-allowsubs-1806522-3.patch1.81 KB

Most of this patch is code from views it self, and from yours.
It's deal better with multi argument settings.
Please test it.

btopro’s picture

btopro commented
Status: Needs review » Reviewed & tested by the community

ignores when they aren't available, renders when they are. Looks ready to go to me

konforti’s picture

konforti commented
Status: Reviewed & tested by the community » Fixed

Commited: http://drupalcode.org/project/google_chart_tools.git/commitdiff/474a4caf...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.