Motivation:

Conditional Rules' plugins should come after Rules' own plugins.
+Add action +Add loop +Add conditional +Add switch +Add while

Proposed solution:

Set module weight to 21.
OTOH: Alphabetical is also a nice order.

CommentFileSizeAuthor
#1 01-1806560-module_weight.patch534 bytesmitchell

Comments

mitchell’s picture

mitchell commented
Status: Active » Needs review
StatusFileSize
new 01-1806560-module_weight.patch534 bytes

Patch attached. Setting to needs review.

zhangtaihao’s picture

zhangtaihao commented

I'm not comfortable about setting module weight since that completely alters module workflow for every single hook. I personally believe the weight attribute of a module should have long been removed.

It would probably be better if Rules sorted plugins when listing them. Otherwise, why not use hook_module_implements_alter() for rules_plugin_info?

mitchell’s picture

mitchell commented
Title: Set module weight to 21 » Alter conditional plugins' module_implements order to adjust UI
Status: Needs review » Active

> It would probably be better if Rules sorted plugins when listing them.
This was my first thought, but my coding chops aren't up to this. My only concern about this was that it might be difficult to get a release with this change anytime soon.

> Otherwise, why not use hook_module_implements_alter() for rules_plugin_info?
I didn't know about this option, but it looks like a good one. It also gives more fine-grained control. Changing title to reflect this.

zhangtaihao’s picture

zhangtaihao commented
Status: Active » Fixed

Fixed in c5f396f.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.