Using modification date in pubDate is suboptimal if you just want to promote new content, not updates. Also, 15 is too small maximum for RSS item count in some cases. This patch against 4.5. adds an option for changing these defaults.

(It would be even better if the admin/users could create custom feeds but that'd be a much bigger change.)

CommentFileSizeAuthor
rss-date-and-len.diff3.25 KBelonen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bèr Kessels’s picture

-1 from me.
IMO the amount of feed-items should be the same as the amount of items on the frontpage. So instead of hardcoded fifteen, we should use variable_get('default_nodes_main', 10).
That way we do not need another setting, and we have consistancy.

Bèr

Bèr Kessels’s picture

-1 from me.
IMO the amount of feed-items should be the same as the amount of items on the frontpage. So instead of hardcoded fifteen, we should use variable_get('default_nodes_main', 10).
That way we do not need another setting, and we have consistancy.

Bèr

elonen’s picture

The RSS stream and the front page are two completely different views. For example, they both take different amounts of screen space when viewed by a human and the RSS is often used for programmatic syndication, for which the front page listing may be too short (this is the case in my system). My point is: different purpose => different configuration.

Morbus Iff’s picture

I disagree with Ber (it's called "default_nodes_main", not "default_nodes_main_and_rss") and agree with elonen. We shouldn't overload one setting in the name of "now we don't need another option, WHEee!". I'd rather let the feature request die then misconstrue the intent of a preference. With that said, I'm also -1ing the patch. The chosen preference names are horrible (I'd rather see "default_nodes_feed"), the preference options aren't friendly ("what the hell is a feed?" - even the addition of "syndication" somewhere would be better), and the help explanation for the dates is far too confusing.

Dries’s picture

Also, patches must apply against HEAD not DRUPAL-4-5. Marking this 'active'.

elonen’s picture

Fine with me, the feature is what matters. Patches from outsiders are usually more of a form of explanation anyway, rather than serious code.

Boris Mann’s picture

Yep, RSS is a different view. This needs to get tackled along with centralizing RSS creation. So, this option would make sense for an Administer > Feeds page (because it is, of course, not just RSS, but also Atom, iCal, etc. etc.)

magico’s picture

Version: 4.5.0 » x.y.z
moshe weitzman’s picture

Version: x.y.z » 5.0
Status: Active » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)