I've implemented shiny on a non-kickstart site. See attached screenshots for some problems.

- checkboxes --> labels are very close
- entityreference headlines could be styled better
- button is very close to the entity reference table
- media button overlays the headline for the field
- inline entity form button is very close to its headline

Comments

dudenhofer’s picture

Assigned: Unassigned » dudenhofer

I'm currently digging into some of these issues, so I'm assigning this to myself.

dudenhofer’s picture

Status: Active » Needs review

I pushed a couple commits to fix the listed issues. Try checking the latest dev and make sure your system looks better. I hadn't done much testing on Ubuntu, but it looks like the checkbox issue was specific to that? I did add some padding, but didn't want to add too much because it would space out the checkboxes a bit further than I'd like in the other browsers I've been testing.

Thanks for the feedback!

lsolesen’s picture

Status: Needs review » Fixed

Things looks better. Good work.

maico de jong’s picture

Status: Fixed » Needs work

Really like this theme, was searching for it after testing out the Kickstart Profile.

Didn't know what's better: Opening a new issue, or posting some more incompatibilities in this post.

See attached sreenshot

- Collapsible fieldsets -> Not having space around the fieldset
- Admin toolbar (admin module) -> Not compatible/menu items not showing full height
- Views Bulk operation -> Bulk operations showing underneath the view on a strange position

maico de jong’s picture

StatusFileSize
new118.1 KB
bojanz’s picture

The position of VBO is correct, I'm just wondering why the arrow is missing...

maico de jong’s picture

StatusFileSize
new59.27 KB

Oh so that's why i was looking at it like something is missing. I looked up the css and found that in contrib.css there is a line: html.js .vbo-views-form fieldset .fieldset-legend {}

Wich sets a background image...
But in my case VBO doesn't have a legend or an element with calss fieldset-legend
I'm using vbo 7.30

Another thing i've noticed is the exposed dat filter wich has a width of 650px set in contrib.css line 812

See attachment

dudenhofer’s picture

Status: Needs work » Needs review

Thanks for posting these MDJ Webdiesten! I pushed a commit to fix these issues here: http://drupalcode.org/project/shiny.git/commit/2dc01a8

I've tested this on basic drupal and kickstart, but please test and let me know that it works for your installation. As far as the VBO form, I removed the padding on the left rather than adding the arrow graphic because if the checkbox was placed anywhere else in the table, then it wouldn't make sense.

Also, if you notice any other incompatibilities, let's make new and more specific issues. Otherwise, I think this issue could remain open forever :P

lsolesen’s picture

@dudenhofer. However, the arrow is good for usability, I think. And when would the checkbox be placed anywhere else?

dudenhofer’s picture

The checkbox is just a field in the view. So some one making their own VBO view could put that field at the end, it could go in the middle... anywhere else other than the first column would make that arrow pointless. It makes sense in Kickstart, where we are controlling the position of that field, but I don't think we should make the assumption that it will always be in one place.

maico de jong’s picture

Status: Needs review » Reviewed & tested by the community

@dudenhofer: Tried latest dev version and the problems mentioned seems all solved.

I will post a new/more specific issue if i notice any other incompatibilities.

Thanks!

dudenhofer’s picture

Status: Reviewed & tested by the community » Fixed

cool, i'm marking this as fixed. thanks for testing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.