This patch is a comprehensive audit of the code base using the coder module running in minor error reporting mode. All errors have been corrected aside from the few areas where coder reported that "you might want a different query". I'm not too concerned about those as they are valid, well formed queries.
Patch includes:

  • Removal of all whitespaces that weren't needed
  • _flip function name changed to _google_chart_tools_flip to preserve namespace (all references updated)
  • draw_chart changed to google_chart_tools_draw_chart to preserver namespace ()
CommentFileSizeAuthor
google_chart_tools-coderaudit.patch29.28 KBbtopro

Comments

konforti’s picture

konforti commented
Status: Needs review » Fixed

About the draw_chart name change, its should be taken under consideration that this function could be in use by other modules to draw a chart. I opened new issue for it: http://drupal.org/node/1807150.

Committed all other changes:
http://drupalcode.org/project/google_chart_tools.git/commitdiff/875e078d...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.