Attached patch removes the dependency on mail_edit and subscriptions with the introduction of a new module - pmsubs. While when I last spoke to chx, I was planning on just introducing an include and shoving all subscriptions related code into a separate file, that wasn't sufficient in light of all the queries in the .install file.

A follow up issue will contain the pmsubs module.

CommentFileSizeAuthor
#1 contrib.tar_.gz_.txt2.85 KBZen
privatemsg_10.patch19.16 KBZen

Comments

Zen’s picture

Zen commented
StatusFileSize
new contrib.tar_.gz_.txt2.85 KB

pmsubs module included inside a directory named contrib. IMO the mail_edit module should be spun out as a separate module or as a sub module for subscriptions.

Also, the first patch in this thread makes a modification irrelevant to this task: it removes the use of the fields name_length and variables from DB queries. This is due to the fact that update_6 adds the name_length field, but the same does not happen in hook_install. The variables field is addressed neither in an update nor in hook_install.

Thanks.
-K

Zen’s picture

Zen commented
Status: Needs review » Fixed

This has been committed [1, 2 with minor modifications.

The pm_subscriptions module is as yet untested.

-K

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.