There are lots of outstanding issues that Coder raised. Most are just standardization issues, but still good to get them fixed.

version = "7.x-2.7"

sites/all/modules/contrib/backup_migrate/backup_migrate.module:
 +216: [critical] file_scan_directory http://api.drupal.org/api/function/file_scan_directory/7() now uses preg regular expressions.
 +674: [critical] Use drupal_set_time_limit http://api.drupal.org/api/function/drupal_set_time_limit/7() instead of set_time_limit http://php.net/set_time_limit().
 +679: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +736: [critical] Use drupal_set_time_limit http://api.drupal.org/api/function/drupal_set_time_limit/7() instead of set_time_limit http://php.net/set_time_limit().
 +1008: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +1010: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME

sites/all/modules/contrib/backup_migrate/backup_migrate.install:
 +234: [critical] Update hooks now return translated strings or throw exceptions
 +246: [critical] Schema descriptions are no longer translated in hook_schema http://api.drupal.org/api/function/hook_schema/6()
 +250: [critical] Schema descriptions are no longer translated in hook_schema http://api.drupal.org/api/function/hook_schema/6()
 +256: [critical] Update hooks now return translated strings or throw exceptions
 +264: [critical] Update hooks now return translated strings or throw exceptions
 +281: [critical] Update hooks now return translated strings or throw exceptions
 +313: [critical] Update hooks now return translated strings or throw exceptions
 +320: [critical] Use absolute path, constructed from DRUPAL_ROOT, when including a file.
 +321: [critical] Use absolute path, constructed from DRUPAL_ROOT, when including a file.
 +336: [critical] Schema descriptions are no longer translated in hook_schema http://api.drupal.org/api/function/hook_schema/6()
 +369: [critical] Update hooks now return translated strings or throw exceptions
 +380: [critical] Context has been added to t http://api.drupal.org/api/function/t/7() as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de").
 +392: [critical] Update hooks now return translated strings or throw exceptions
 +422: [critical] Update hooks now return translated strings or throw exceptions

sites/all/modules/contrib/backup_migrate/backup_migrate.js:
 File: [critical] JavaScript should be compatible with other libraries than jQuery.

sites/all/modules/contrib/backup_migrate/includes/backup_migrate.drush.inc:
 +222: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME

sites/all/modules/contrib/backup_migrate/includes/destinations.db.mysql.inc:
 +407: [critical] hook_footer http://api.drupal.org/api/function/hook_footer/6() and theme_closure http://api.drupal.org/api/function/theme_closure/6() were removed.

sites/all/modules/contrib/backup_migrate/includes/destinations.email.inc:
 +124: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME

sites/all/modules/contrib/backup_migrate/includes/destinations.inc:
 +33: [critical] Context has been added to t http://api.drupal.org/api/function/t/7() as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de").
 +93: [critical] Context has been added to t http://api.drupal.org/api/function/t/7() as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de").
 +291: [critical] drupal_set_title http://api.drupal.org/api/function/drupal_set_title/7() now uses check_plain http://api.drupal.org/api/function/check_plain/7() by default
 +323: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +345: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +728: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +737: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +943: [critical] Use absolute path, constructed from DRUPAL_ROOT, when including a file.

sites/all/modules/contrib/backup_migrate/includes/destinations.nodesquirrel.inc:
 +84: [critical] Context has been added to t http://api.drupal.org/api/function/t/7() as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de").
 +487: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME

sites/all/modules/contrib/backup_migrate/includes/destinations.s3.inc:
 +180: [critical] Context has been added to t http://api.drupal.org/api/function/t/7() as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de").

sites/all/modules/contrib/backup_migrate/includes/files.inc:
 +38: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME

sites/all/modules/contrib/backup_migrate/includes/filters.backup_restore.inc:
 +162: [critical] Use absolute path, constructed from DRUPAL_ROOT, when including a file.

sites/all/modules/contrib/backup_migrate/includes/filters.encryption.inc:
 +57: [critical] Context has been added to t http://api.drupal.org/api/function/t/7() as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de").

sites/all/modules/contrib/backup_migrate/includes/filters.inc:
 +20: [critical] Use absolute path, constructed from DRUPAL_ROOT, when including a file.

sites/all/modules/contrib/backup_migrate/includes/filters.utils.inc:
 +146: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME

sites/all/modules/contrib/backup_migrate/includes/schedules.inc:
 +332: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
 +356: [critical] For improved performance, it is highly recommended that time http://php.net/time() is replaced with REQUEST_TIME
CommentFileSizeAuthor
#3 please_run_through_coder-1807480-3.patch343.17 KBaburke626

Comments

kenorb’s picture

kenorb commented
Version: 7.x-2.4 » 7.x-2.7
Issue summary: View changes
aburke626’s picture

aburke626
she/her
Primary language English
Location Lehighton, PA, US
commented
Version: 7.x-2.7 » 7.x-3.1
aburke626’s picture

aburke626
she/her
Primary language English
Location Lehighton, PA, US
commented
StatusFileSize
new please_run_through_coder-1807480-3.patch343.17 KB

Attached is a patch that fixes all of the code standards issues in the module. However, there were a lot of class-name related issues, which I did not fix, as I thought that should probably be a separate issue, as it would affect anyone whose code depends on this module. I'd be happy to fix it in another issue. Example of what's remaining:

FILE: /Applications/MAMP/htdocs/backup_migrate/includes/destinations.file.inc
--------------------------------------------------------------------------------
FOUND 51 ERROR(S) AFFECTING 25 LINE(S)
--------------------------------------------------------------------------------
  13 | ERROR | Class name must begin with a capital letter
  13 | ERROR | Class name must use UpperCamel naming without underscores
  14 | ERROR | Class property $supported_ops should use lowerCamel naming
     |       | without underscores
  14 | ERROR | The var keyword must not be used to declare a property
  14 | ERROR | Visibility must be declared on property "$supported_ops"
  27 | ERROR | Method name "backup_migrate_destination_files::type_name" is not
     |       | in lowerCamel format, it must not contain underscores
  27 | ERROR | Visibility must be declared on method "type_name"
  34 | ERROR | Method name "backup_migrate_destination_files::get_realpath" is
     |       | not in lowerCamel format, it must not contain underscores
  34 | ERROR | Visibility must be declared on method "get_realpath"
  41 | ERROR | Method name "backup_migrate_destination_files::_save_file" is
     |       | not in lowerCamel format, it must not contain underscores
  41 | ERROR | Visibility must be declared on method "_save_file"
  71 | ERROR | Method name "backup_migrate_destination_files::can_read_file" is
     |       | not in lowerCamel format, it must not contain underscores
  71 | ERROR | Visibility must be declared on method "can_read_file"
  78 | ERROR | Method name "backup_migrate_destination_files::load_file" is not
     |       | in lowerCamel format, it must not contain underscores
aburke626’s picture

aburke626
she/her
Primary language English
Location Lehighton, PA, US
commented
Status: Active » Needs review
couturier’s picture

couturier commented
Status: Needs review » Postponed (maintainer needs more info)

Can you confirm if this is still needed for the 7.x-3.2 release?

couturier’s picture

couturier commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing after more than two weeks with no activity.