Saving and rendering in empty region for 'Global: unfiltered' text does not work

I think the logic in the render function needs to be changed too as $empty should be TRUE?

Moving back to views for testing.

hmm, yeah I see what you mean. So the logic is pretty weird there really; we are relying on the actual $empty value to be FALSE for headers/footers and only the option being set to show actual empty text.

So atm, the empty text being rendered is dependent on this:

if ($this->definition['plugin_type'] == 'empty') {
  $this->options['empty'] = TRUE;
}

So this will never get set to TRUE, because the plugin_type will always be 'area' and not empty.

If we change the conditional in init to check the handler_type and not the definition, I think it works as it should. I also added the same conditional that we are using in the render methods into the TestExample handler too, as the tests weren't picking up that this wasn't working before.

The logic is still quite confusing, we should review this and maybe base it more on the handler_type that gets passed in for areas instead?

Ok, new patch. Changed a few other things...

• Checked that handler_type isset, it might not be I guess (especially in the UI maybe).
• Added empty = TRUE to options on the area handlers in the tests. The view returns no results, so this was totally not working before :)
• Changed the logic in renderHeader and renderFooter methods on displayPluginBase as they were doing $empty = !empty($this->view->result), I think this needs to be the other way around.

Not sure what else we need to include on the d7 port?

Yeah, might as well.

Splitting them up just to be sure, will commit if it comes out as expected.

Committed!
http://drupalcode.org/project/views.git/commit/418cd1e

Patch in #15 is the D7 one.

Let's test the D7 version.

The 6 year old patch at #23 to views_handler_area.inc and views_plugin_display.inc does not apply to the latest views 7.x-3.x-dev and if still applicable needs to be rerolled.

Checking patch handlers/views_handler_area.inc...
error: while searching for:
   */
  function init(&$view, &$options) {
    parent::init($view, $options);
    if ($this->handler_type == 'empty') {
      $this->options['empty'] = TRUE;
    }
  }

error: patch failed: handlers/views_handler_area.inc:27
error: handlers/views_handler_area.inc: patch does not apply
Checking patch plugins/views_plugin_display.inc...
error: while searching for:
   * Render the header of the view.
   */
  function render_header() {
    $empty = !empty($this->view->result);
    return $this->render_area('header', $empty);
  }

error: patch failed: plugins/views_plugin_display.inc:2568
error: plugins/views_plugin_display.inc: patch does not apply

@Chris Matthews, Please review this rerolled patch & share your feedback on the same.

Thanks!..

Looks like there's a typo in the render_footer() method of #26 -- a double dollar-sign (i.e. $$empty).

Attached is a revised patch that's the same as #26, but with the typo fixed.

Can we get this in? We need this for unfiltered text to work on a view that should only display a header when the view is not empty :)