Convert internal handling of date formats to CMI

Here's the our last patch from the previous issue.

set to review to see if we get the same number of fails (~20)

not only did the patch not apply, but if it had it wouldn't install. Here's the rerolled patch:

* fixed the broken update function name
* fixed improper use of the date format save.

Wow, I was having frustrating internet connectivity issues last night and didn't think this actually posted. setting to review to see if this can at least be applied.

+++ b/core/modules/system/config/system.date.ymlundefined
@@ -0,0 +1,50 @@
+formats:
+  system_long:
+    name: "Default Long Date"
+    pattern: 'l, F j, Y - H:i'
+    locked: 0
+  system_medium:
+    name: "Default Medium Date"
+    pattern: 'D, m/d/Y - H:i'
+    locked: 0
+  system_short:
+    name: "Default Short Date"
+    pattern: 'm/d/Y - H:i'
+    locked: 0
+  html_datetime:
+    name: "HTML Datetime"
+    pattern: 'Y-m-d\TH:i:sO'
+    locked: 1
+  html_date:
+    name: "HTML Date"
+    pattern: 'Y-m-d'
+    locked: 1
+  html_time:
+    name: 'HTML Time'
+    pattern: 'H:i:s'
+    locked: 1
+  html_yearless_date:
+    name: 'HTML Yearless date'
+    pattern: 'm-d'
+    locked: 1
+  html_week:
+    name: 'HTML Week'
+    pattern: 'Y-\WW'
+    locked: 1
+  html_month:
+    name: 'HTML Month'
+    pattern: 'Y-m'
+    locked: 1
+  html_year:
+    name: 'HTML Year'
+    pattern: 'Y'

Here's where we'll modify the config of formats to store format strings that support the legacy system and IntlDateFormatter

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/FormatDateTest.phpundefined
@@ -35,15 +35,19 @@ class FormatDateTest extends WebTestBase {
+      ->set('timezone.user.configurable', 1)

Allow the regional config patch to handle this.

I think this patch has most of this working so I'm leaving this in for now until the regional config patch diverges.

Also, we previously discussed how using ConfigEntities / Configurables could benefit this patch. I'm not sure if that effort should be tackled with this patch or a follow up.

Ah, looks like my previous patch was uploaded twice. ok, here's the patch I really meant to test.

My previous fixes weren't included in that patch. This one fixes:

• system.install: updated the function name to use a named that is available
• cleaned up extra code that was the result of an unsuccessful reroll

I've run a test locally and I'm passing it. The funny thing is I've only cleaned up some stray code that seem to have been misplaced after I rerolled that patch. I'm posting this patch to see how many other things are now magically fixed.

I've run a test locally and I'm passing it. The funny thing is I've only cleaned up some stray code that seem to have been misplaced after I rerolled that patch. I'm posting this patch to see how many other things are now magically fixed.

I've fixed a few of the fails here but I don't know how many. This patch seems to fail when saving "custom" date formats.

@marcingy
I think it's fine if you want to mark this issue postponed. I've mainly opened this issue up so that I can do everything I can to not block the work you are planning to do on the regional CMI issue. I plan to continue to post patches here until we can have a code-level discussion about the merits of our two designs. Please don't take that action as a rejection of your involvement. I just don't want to stop working on a solution.

I have very little time to work on core now that my day-job has intensified. I hope the extra load is resolved soon (once we hire a few more Drupal devs). Even after then, I hope to make the most of my time. If you want we can collaborate over irc, Skype, Google+ Hangouts, or whatever would be beneficial to help this issue come to a close.

Please let me know what is feasible.

You're right this one is finished as a result of that other issue.