Allow area handlers to override the page title when used in an empty area. [#1808542]

Posted by damiankloip on October 10, 2012 at 12:19pm

4 followers

Issue Summary

Currently there is a custom area handler used for the empty text in #1806334: Convert the node listing at /node to Views. This should be an option on area handlers to override the title, if the view is empty.

I have code for this but it would be better to wait for #1807624: Saving and rendering in empty region for 'Global: unfiltered' text does not work to be committed, as it fixes the empty area handling. I will then re roll what I have for this.

Posted by damiankloip on October 10, 2012 at 12:20pm

Title:

Allow area handlers to override the page title when used in empty area.

» Allow area handlers to override the page title when used in an empty area.

Posted by dawehner on October 10, 2012 at 12:32pm

For me it seems to make more sense to have an extra area handler which can override the title and one which can just display some custom text.

Posted by damiankloip on October 10, 2012 at 12:43pm

Good idea. I'll modify it for that!

Posted by damiankloip on October 10, 2012 at 1:11pm

Status:

active

» needs review

Attachment	Size	Status	Test result	Operations
1808542-4.patch	1.88 KB	Idle	PASSED: [[SimpleTest]]: [MySQL] 2,838 pass(es).	View details

Posted by dawehner on October 10, 2012 at 1:16pm

Status:

needs review

» needs work

+++ b/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -0,0 +1,49 @@
+  protected function defineOptions() {

Can haz commentz?

+++ b/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -0,0 +1,49 @@
+    if (!empty($this->options['title'])) {
+      $this->view->setTitle(filter_xss_admin($this->options['title']), PASS_THROUGH);

Does this support tokens? We might refer them in the form as well.

+++ b/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -0,0 +1,49 @@
+    return;

Just a nitpick: An empty string sounds helpful.

Posted by damiankloip on October 10, 2012 at 2:46pm

Status:

needs work

» needs review

Thanks for the review. Comments added, render() now returns an empty string. I have also added a test for this.

I have created a new issue so we can move the token code into the AreaPluginBase class: #1808648: Move tokenization form code into AreaPluginBase and use that in this plugin.

Attachment	Size	Status	Test result	Operations
1808542-6.patch	3.21 KB	Idle	PASSED: [[SimpleTest]]: [MySQL] 3,064 pass(es).	View details

Posted by tim.plunkett on October 10, 2012 at 3:06pm

+++ b/lib/Drupal/views/Tests/Handler/AreaTest.phpundefined
@@ -104,4 +104,30 @@ class AreaTest extends HandlerTestBase {
+    $view->initDisplay('page');

I thought we were switching to 'page_1' everywhere?

+++ b/lib/Drupal/views/Tests/Handler/AreaTest.phpundefined
@@ -104,4 +104,30 @@ class AreaTest extends HandlerTestBase {
+          'id' => 'title',
+          'table' => 'views',
+          'field' => 'title',
+          'admin_label' => '',
+          'label' => '',
+          'empty' => '0',
+          'title' => 'Overridden title',

This is indented too far.