Move tokenization form code into AreaPluginBase

I think the best way to do this would be probably to actually move this into a global helper method because token form help might be helpful on:

• View title
• Field
• Area
• Style/Row plugins, for the available tokens for classes.

+++ b/lib/Drupal/views/Plugin/views/area/AreaPluginBase.phpundefined
@@ -92,6 +91,60 @@ abstract class AreaPluginBase extends HandlerBase {
+   * Form Helper function to add tokenization form elements.

+++ b/lib/Drupal/views/Plugin/views/area/TextCustom.phpundefined
@@ -18,21 +18,26 @@ use Drupal\Core\Annotation\Plugin;
-    unset($form['content']['#wysiwyg']);

I guess Helper should be lowercase here, maybe the description could make it clear that the form is altered and not returned, but i don't care that much about that.

+++ b/lib/Drupal/views/Plugin/views/area/AreaPluginBase.phpundefined
@@ -92,6 +91,60 @@ abstract class AreaPluginBase extends HandlerBase {
+      $output = '<p>' . t('The following tokens are available. If you would like to have the characters \'[\' and \']\' please use the html entity codes \'%5B\' or  \'%5D\' or they will get replaced with empty space.' . '</p>');
...
+          $output .= theme('item_list',
...
+        '#value' => $output,

I know this is sort of out of scope, but couldn't we all this just replace by proper render arrays?

+++ b/lib/Drupal/views/Plugin/views/area/AreaPluginBase.phpundefined
@@ -92,6 +91,59 @@ abstract class AreaPluginBase extends HandlerBase {
+      $form['token_help']['markup'] = array(

That's nice, what about help instead?

Awesome!

I attached one patch with the reroll.

All of this looks very straight-forward, apart from this:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/area/TextCustom.phpundefined
@@ -18,21 +18,26 @@
-class TextCustom extends Text {
+class TextCustom extends AreaPluginBase {

Like the review I did this weekend, the old code makes a ton more sense to me. I have no idea what an "AreaPluginBase" is, and the PHPDoc for that class tells me:

/**
 * Base class for area handlers.
 *
 * @ingroup views_area_handlers
 */
abstract class AreaPluginBase extends HandlerBase {

Not. Helpful. :)

I asked damian on IRC and he said:

"An area plugin is the base plugin class we use for Header, footer, empty areas in views."

That's much more helpful, though I'm not sure I would call a thing with such a description an "area plugin."

ANYWAY.

None of that is related to the patch at hand, which looks fine to me now that I understand what an AreaBasePlugin is (this is just moving the token integration into the base class so all derivations can use it), so...

Committed and pushed to 8.x.

But let's get a follow-up to both document and possibly rename AreaPluginBase cos that shit is whack. :)

Yep, properly documenting the base plugin and handler types is our next priority for documentation. It might be after Dec. 1 but it's also one of the few documentation tasks I'm okay with doing before then and it's my next priority. :) There isn't really a better name for it I don't think, but it does need docs to say WTF it is.