This module assumes products have only one weight field. But it's feasible for products to have a weight field for their actual weight, and another weight field to describe some other aspect of the product.

For example:

- maximum weight for a child's bike seat / baby carrier / etc
- suitable body weight for certain sports products
- weight of individual components, such as dry weight for food

CommentFileSizeAuthor
#12 commerce_physical-selecting_field_used_for_shipping_multiple_physical_fields-1808716-12.patch4.64 KBcvangysel

Comments

johnv’s picture

johnv
Primary language Dutch
commented

@joachim, IMO this weight (+ measures) is for the box /tin/can/bag the product is in, to be used for storage and shipping calculations. The weight you are referring to seems more like a 'normal' product attribute.

joachim’s picture

joachim commented

Precisely.

But this module is making the assumption that there is only one field of type 'physical_weight' on the product when calculating how much a product weighs for shipping purposes.

Whereas the product can have more than one weight field: one for its shipping weight, and others which describe other things for the benefit of the consumer.

mrpeanut’s picture

mrpeanut commented

@joachim In your example, the other weight fields (e.g., maximum weight, suitable body weight, etc.) won't affect shipping. Because of that, you could simply use integer fields. Weight fields are pretty much strictly for shipping (in this context).

joachim’s picture

joachim commented

> Because of that, you could simply use integer fields

Of course I could. But I don't want to! I would like the benefit of the weight field type for these: selection of units, conversion, etc etc.

> Weight fields are pretty much strictly for shipping (in this context).

Yes, and that is my point: they should not be!

mrpeanut’s picture

mrpeanut commented

I would like the benefit of the weight field type for these: selection of units, conversion, etc etc.

Ahh, gotcha. I hadn't considered that. Why can't you simply add another weight field to your product type?

joachim’s picture

joachim commented

Because this module assumes there is only one, and uses that as the order weight. Which is what this bug report is about.

dwkitchen’s picture

dwkitchen commented

If the UI was implemented in this module #1499538: Commerce Physical UI the the calculation can use the default defined field rather than just the first physical field it comes across.

cvangysel’s picture

cvangysel commented
Status: Active » Fixed

Marking this as fixed as the issue has been resolved.

joachim’s picture

joachim commented
Status: Fixed » Active

I don't understand how this has been fixed -- the other issue pointed to is not fixed either, and it doesn't yet implement what is needed here.

dwkitchen’s picture

dwkitchen commented

Indeed, once the UI has been implimented the code that does these calculations will need to changed to target on those fields only.

cvangysel’s picture

cvangysel commented

Woops, sorry. When I first scanned over this issue I had the impression that it wasn't really needed anymore. I probably read over the comments too quickly.

cvangysel’s picture

cvangysel commented
Status: Active » Needs review
StatusFileSize
new commerce_physical-selecting_field_used_for_shipping_multiple_physical_fields-1808716-12.patch4.64 KB

After reviewing everything I don't necessarily agree with the approach taken in #1499538: Commerce Physical UI, for me it seems that the Field UI does a good enough job and the code contained in that sandbox only makes things more complicated.

Attached you can find a patch that implements the functionality requested in this issue. It's based upon a previous patch I wrote for this module: #1390190: hide shipping pane for non-shipping product. You first need to apply the patch in that issue before applying this one. The reason for this is that the previous patch already adds an admin UI to Commerce Physical.

zkrebs’s picture

zkrebs commented
Issue summary: View changes

If I am selling a product that has two weights

1 oz product
2 oz packaging

How can I get it to accommodate both weights in shipping calculations?

johnv’s picture

johnv
Primary language Dutch
commented

IMO this is solved via an alter hook since 2011.
See http://cgit.drupalcode.org/commerce_physical/commit/?id=ca64ce2
And the api.php file.

See also https://www.drupal.org/node/2403067

zkrebs’s picture

zkrebs commented

johnv can you explain in simple lay person terms what that patch does on the second link?

johnv’s picture

johnv
Primary language Dutch
commented

The second link is just to inform you that you may encounter the problem of that issue in case you want to specify your field. I did not use or test any of both links.
But if the first link works, this issue is solved/a duplicate.

jharbert’s picture

jharbert commented

Speaking of multiple weights. Is there any way to make the Physical Weight Textfield be a List(Text) with Select Widget.

So for the Allowed Selections I would have

10|500 @ .25 each
100|5000 @ .20 each

So from the user's perspective they would be selecting product quantity but in the backend they would be choosing shipping weight. Ex. 10 lbs or 100lbs