exact resize called on wrong event

szigeti - October 4, 2007 - 22:43
Project:Image Exact Sizes
Version:5.x-0.1
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

It's me again. (:
There are two operations with Image nodes that should invoke exact_size. One is 'insert', other is 'update'. Currently it is called at 'validate' operation which is incorrect.
Location: image_exact.module line 88

Wrong:
if ($node->type == 'image' && $op == 'validate' && variable_get('image_exact_thumbs', 1)) {
Right:
if ($node->type == 'image' && in_array($op, array('insert', 'update')) && variable_get('image_exact_thumbs', 1)) {

Please review
Thanks

#1

szigeti - October 4, 2007 - 22:48

Sorry it's 'submit' and not 'insert'.
So the right line is:
if ($node->type == 'image' && in_array($op, array('submit', 'update')) && variable_get('image_exact_thumbs', 1)) {

Thanks

#2

joshk - March 7, 2008 - 20:18
Status:needs review» closed

applied

 
 

Drupal is a registered trademark of Dries Buytaert.