Posted by szigeti on October 4, 2007 at 10:43pm
Jump to:
| Project: | Image Exact Sizes |
| Version: | 5.x-0.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
It's me again. (:
There are two operations with Image nodes that should invoke exact_size. One is 'insert', other is 'update'. Currently it is called at 'validate' operation which is incorrect.
Location: image_exact.module line 88
Wrong:
if ($node->type == 'image' && $op == 'validate' && variable_get('image_exact_thumbs', 1)) {
Right:
if ($node->type == 'image' && in_array($op, array('insert', 'update')) && variable_get('image_exact_thumbs', 1)) {
Please review
Thanks
Comments
#1
Sorry it's 'submit' and not 'insert'.
So the right line is:
if ($node->type == 'image' && in_array($op, array('submit', 'update')) && variable_get('image_exact_thumbs', 1)) {
Thanks
#2
applied