Hello, what's the plan to upgrade userpoints module to 6.x?
Is it going to be 2.xAPI or 3.xAPI?

Comments

kbahey’s picture

kbahey commented

Depends.

3.0 API has not stabilized yet though. Needs some testing, and jredding is working on one more feature for it.

If people submit working and tested patches for upgrading both branches to 6.x, we will have both on 6.x. Otherwise it will be whatever we have time for and/or what clients ask for.

dami’s picture

dami commented

Thanks for your reply. Do you know approximately when will 3.0 API be released? In a few weeks, a couple months ...?
I use userpoints.module on my site, so I am interested in helping with the 6.x upgrade.
Maybe I should just wait a bit longer for the 3.0 API to be stable.
Cheers!

jredding’s picture

jredding commented
Assigned: Unassigned » jredding

3.x is not quite done yet although its close. If you'd like to help with completing the 3.0 upgrade or if you're serious about helping with the 6.x upgrade just let me know. The code has been checked into CVS and no official release (Dev or otherwise) has been created.

I'd love for someone to help me out with some reporting issues around categorization as well as do some beta testing/debugging.

Ping back via the issue tracker or via my contact page (both would be best to keep everyone on the same page)

dami’s picture

dami commented

I'd like to help out but don't expect too much from me. There is just too much going on and I don't know how much time I can find to work on it.

What's your plan on 3.0 API? I suggest release it for drupal 6.x only. One less branch of codes to worry about ....

Anyway, I just grabbed the latest code from drupal-5--3 branch, and spent some time on it this afternoon. I didn't do any testing or debugging but mainly focused on upgrading to 6.x:
1. userpoints.module
1) Added/Modified hook_menu, hook_help and hook_theme
2) Some minor code clean up with the help of coder module.
3) Haven't touched anything related to FAPI3 changes yet. Will leave it for later.

2. userpoints.install
1) Modified it to use hook_schema(). I am not familiar with it, so it's guess work and will need some help there later.

My plan is to have a 'roughly working' (means no white-screen-of-death errors or similar gross failures) 6.x version of userpoints 3.0 first. Then refine it a bit more to take advantage of some 6.x changes, like separation of admin code etc. After that, maybe we can work from there for further debugging or adding more cool features of 3.0 API.

I will post the code here when it's mostly ready. It probably will just be a zip file instead of patches, since there are lots of changes and the code will be in a new branch anyway.

jredding’s picture

jredding commented

Woah before you go too deep don't forget that the 5--3 branch is in development and will change thus if you were making a patch it'll fail against the "final product". I just don't want you spending a lot of time on something that is definitely going to change.

I'm almost finished with it but my time is also limited. You time on hook_menu, .install, etc. are definitely appreciated though! I haven't done a D6 upgrade yet so I not exactly sure what needs to be done.

jredding’s picture

jredding commented

Woah before you go too deep don't forget that the 5--3 branch is in development and will change thus if you were making a patch it'll fail against the "final product". I just don't want you spending a lot of time on something that is definitely going to change.

I'm almost finished with it but my time is also limited. Your time on hook_menu, .install, etc. are definitely appreciated though! I haven't done a D6 upgrade yet so I am not exactly sure what needs to be done.

dami’s picture

dami commented

Thanks, I understand and that's part of the reason why I suggested release 3.0APi for drupal 6.x only.

For the upgrading itself, the most challenging part, for me, is the admin forms. For example, the userpoints_admin_txn() form actually handles both 'edit' and 'add' cases. It uses lots of ifs and switches and hidden form values. We may want/need to break it up, so 'edit' and 'add' has their own admin_txn forms...OK, I'll stop here, and wait for your decision or a stable 3.0 API release:)

jredding’s picture

jredding commented

Version 3 has a freeze. I'm done with all the changes and now I need some serious beta testing on it. The .install file has me a little worried because of the schema changes necessary for categorization. Also a lot of stuff was changed around since my last commit a few days agao (420 or so new lines, 160 less lines) in all its a pretty major changes from 2.14.

Please, please, please help me BETA test this. I need some heavy duty feedback.

I already ran it through coder.module so you don't have to ;) we're clean as a whistle.

As for the D6 upgrade. Since the code was *just* completed from D5 and hasn't been fully vetted yet I'm going to strongly suggest getting a stable release on D5 first and then a D6 upgrade. A lot of people won't be upgrading to D6 for a while and v3 fixes a lot of the bugs currently in the issues queue.

The definite answer, however, lies with kbahey. Its his module after all. I'm just some guy screwing up the API ;)

dami’s picture

dami commented

I suggest create a 5.x-3.x-dev release, it'd attract more people to grab and test it.

dami’s picture

dami commented

Out-of-topic: just did 5-minute quick testing. Looks like 'tid' & 'pid' fields are missing in userpoint_install() schema.
I will do more testing later in the week and submit issues when I find them.

jredding’s picture

jredding commented

ya.. a 5.3x dev release would make things easier but I'll leave that up to kbahey. He hasn't had a chance to review/approve the changes. Once he reviews/approves the changes I'll tag it for a dev release.

jredding’s picture

jredding commented

.install has been modified and changes committed. The .install file needs to most eyes on it as the Schema has changed slightly. Additionally there is little (no?) code for psql. Maybe someone out there can help with this.

dami’s picture

dami commented

Did a bit more testing on basic functions. Basic functions like add/delete/moderate points seem to be working properly.
However when I did a reset/retro, the points weren't re-calculated correctly. And the 'max points' field doesn't reflect the max points either.

I remember seeing userpoints category/taxonomy setup last night, but couldn't find it now. Can you point me the url?

Let's keep this thread for 6.x update only. I will test more and report back in a separate issue after 5.3-dev is tagged.

dami’s picture

dami commented

Zap my last post, somehow I grabbed the wrong branch.

dami’s picture

dami commented

Typo in .install file line 17: "NOT auto_increment" should be "NOT NULL auto_increment"

jredding’s picture

jredding commented

Moving the debug talk on v3 to:
http://drupal.org/node/183812

Returning thread back to talk on D6 upgrade.

dami’s picture

dami commented

Jredding and Kbahey: Please drop a line here when you think 3.0 API is stable enough for 6.x upgade work to start. Thanks.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Component: Code: userpoints » Code: userpoints API

I'd say now is a good time, right?

jredding’s picture

jredding commented

ya I'd say it is. Its in the works and I'm ready to finish it up if need be BUT.. I'd really like to sneak some more changes to push the module further down the path of uber-points module to conquer the world. Could you comment?
http://groups.drupal.org/node/10539

I'd like to do all that before we release a stable 6.0 (note this is not new coding just reorganization)

jredding’s picture

jredding commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.