Download & Extend
More Comments » Issues

Recall other modules javascript behaviors after ajax comment load

Posted by kongoji on October 12, 2012 at 6:34am
Project:More Comments
Version:7.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi,
I kindly ask you if it would be possible to add a Drupal.attachBehaviors(data) after the ajax load is completed.
That would let other modules' javascripts to attach their behaviors to the new loaded comments.
I attach a patch below.
Thank you

Login or register to post comments

Comments

#1

Posted by kongoji on October 12, 2012 at 6:35am

Here is the patch

AttachmentSize
morecomments_attachbehaviours-1810740-1.patch 440 bytes

#2

Posted by dagmar on October 12, 2012 at 7:05pm
Status:active» needs work

+++ b/morecomments.js
@@ -14,6 +14,7 @@
+   Drupal.attachBehaviors(data);

Bad indentation. Use spaces instead of tabs please.

#3

Posted by timofey on October 12, 2012 at 9:37pm
Status:needs work» needs review

rerolling

AttachmentSize
morecomments.patch 457 bytes

#4

Posted by timofey on October 12, 2012 at 9:42pm

Fixed line format, reroll

AttachmentSize
morecomments.patch 446 bytes

#5

Posted by kongoji on October 13, 2012 at 12:46pm

I tested a little bit more the patch and there was still a case where it wouldn't work.
To make behaviors always work we have to attach them on the morecomments-button's parent.
This is the new patch, it works in every case I tested.

AttachmentSize
morecomments_attachbehaviors-1810740-5.patch 574 bytes

#6

Posted by dagmar on January 30, 2013 at 8:34pm
Status:needs review» fixed

Thanks! This also fix #1872792: Problem with ajax_comments.

Committed & Pushed to 7.x-1.x.

#7

Posted by System Message on February 13, 2013 at 8:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here