It seems like all average lifetime issue statistics are the same on d.o:

http://drupal.org/project/issues/statistics/img_assist
http://drupal.org/project/issues/statistics/imce
http://drupal.org/project/issues/statistics/admin_menu

CommentFileSizeAuthor
#2 fix_issue_stats.patch2.29 KBChrisKennedy

Comments

hunmonk’s picture

hunmonk commented

feel free to dig for the problem -- we've got a lot of other stuff that's coming in ahead of this... :)

ChrisKennedy’s picture

ChrisKennedy commented
Status: Active » Needs review
StatusFileSize
new fix_issue_stats.patch2.29 KB

The error was introduced when db_rewrite_sql was added by: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/project_iss... (due to http://drupal.org/node/168760).

In particular, db_rewrite_sql() doesn't do token replacement - db_query does. So the parentheses need to be changed. I don't really understand how db_rewrite_sql works though, so this might not entirely fix the problem and I can't tell from my test environment.

Also, I fixed a nearby error in the taxonomy display, that appears to have been introduced back in June 2006.

ChrisKennedy’s picture

ChrisKennedy commented

Okay I was able to test it and confirm that it does fix the bug. The rest of the db_rewrite_query() changes appear to be correct too.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Thanks! Committed your db_rewrite_sql() fixes in here to DRUPAL-4-7, DRUPAL-4-7--2, DRUPAL-5 and HEAD. Moved your breadcrumb fix into a separate issue: http://drupal.org/node/185378

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.