Use theme('username') in messages and other formated output

In buddylist_deletebuddy_submit():

+ drupal_set_message(t('!username has been removed from your @buddylist', array('!username' => theme('username', $removeuser)) + buddylist_translation()));

$removeuser does not exist in this context.

Looks good, it'll be great to be able to theme these. Two more things I noticed while testing:

1. In theme_add_to_buddylist_link():

+ return l(t('Add'), 'buddy/add/' . $buddyuser->uid, array('title' => 'Accept'), drupal_get_destination(), NULL, FALSE, TRUE);

'Accept' doesn't really make sense as a title here. This link appears on a user profile page, where you can either directly add the user as a buddy, or make a request to add them. Accepting a request happens elsewhere.

2. You missed one in buddylist_addbuddy_submit():

drupal_set_message(t('%name will be be notified the next time s/he logs in.', array('%name' => $form_values['name'])));

(also, notice the repeated word "be" in that sentence).

There are two more, in buddylist_cancel_add() and buddylist_cancel_remove(), but those functions seem to be dead code AFAICT.

This one looks good. I fixed that "will be be notified" and a second instance of the same thing - otherwise this patch is identical to your last one.

I'm not sure about the mails though - theme('username') normally generates HTML output, which you might not want in a mail.