Closed (fixed)
Project:
Domain finder
Version:
7.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2012 at 16:45 UTC
Updated:
20 Oct 2012 at 07:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
dj1999 commentedHi,
here is a patch to help if get back empty result.
Regards,
Joe
Comment #2
jake1000 commentedPatch results in the same error. Screenshot attached. Also, the website searched for is an existing website, so there should be results returned.
Comment #3
jake1000 commentedI just changed line 152 to this:
if (isset($variables['result']) && isset($variables['result']['regrinfo']['domain']['name'])) {
and now I am getting the following issue shown in the attachment on shared hosting environment, only after running a few URL's through. You will notice there was a URL that needed normalizing that was ran before these empty results appeared. Also, sometimes the output_text doesn't appear, and sometimes the drupal_set_message will disappear or in the function "domain_finder_normalize_domain_name" the message will appear twice when searching for multiple different URL's in a row.
Comment #4
jake1000 commentedHere are the missing messages
Comment #5
jake1000 commentedmessages showing up twice when entering differently formatted URL's.
Comment #6
dj1999 commentedSorry I could not reproduce empty whois result with your settings.
I made some changes please test this tree or use
git clone --recursive --branch 7.x-1.x-dev http://git.drupal.org/project/domain_finder.gitI waiting for your results.
Regards,
Joe
Comment #7
jake1000 commentedThe new code results in the following error. It seems that these errors with the patched code from last time were only happening after entering "www."
If you don't enter the prefix, there are no errors so the www. is breaking it.
Comment #8
dj1999 commentedHere a patch to help it. What is with empty whois result?
Comment #9
jake1000 commentedThe new code provides a new message that there are empty results... but for most of these there should be results returned. In the attachment, www.yahoo.com was searched for and returned empty results. The problem is with the "www." prefix. The code is not stripping the prefix correctly. When that is fixed, the empty result problem will go away.
Comment #10
jake1000 commentedAnother error with new tree and code.
Comment #11
dj1999 commentedI do not know. I have ran your searches same settings and I got the properly result. See pictures.


Comment #12
jake1000 commentedI don't know what to say then. When you search without including the www. prefix, the code works fine. When you start to enter www., then it breaks down. I think your function "domain_finder_normalize_domain_name" is not correctly written.
Comment #13
dj1999 commentedBut if you see my results what search just "www." and "www.yahoo.co" working properly too.
It is easy to test it.

Comment #14
jake1000 commentedYou're right. Could it be an issue with shared hosting env?
Comment #15
jake1000 commentedOne more screenshot for you to take a look at. Why would it return that yahoo.org is free?
Comment #16
dj1999 commentedI do not know. I get always right result. I use phpWhois version 4.2.2 Jul-09-2011. Check your phpWhois version please.
Comment #17
dj1999 commentedComment #18
jake1000 commentedOkay, I installed the module on a fresh install and just like before, it worked for awhile, with the exception of the .org domain showing as free (in the screenshot below), but now it is returning all empty results only in the shared hosting environment. I ran about 20 different URLs through in a row before the empty results began coming up for every entry. Could it be a caching issue?
Comment #19
jake1000 commentedComment #20
dj1999 commentedBecause I get correct results is to difficult to help but created a patch. Now default is 'unavailable'. On case is free if registered value is 'no'. Please test it.
Comment #21
jake1000 commentedSame result with the patch. There must be something with the shared hosting environment that is causing it. Like I said, it works for a few searches on a fresh install before the empty results start appearing in shared hosting, local works fine. I guess it's just not going to work for me. Thanks for trying to help.
edit: The double messages in attachment from comment #5 are not appearing any more with the changed values in the last patch.
Comment #22
dj1999 commentedI think our bugs are repaired. Hosting is an other question.
Comment #23
dj1999 commented