non-object in _taxonomy_menu_nodeapi_helper() line 487 of ..taxonomy_menu/taxonomy_menu.module [#1811850]

Get error on node save. Error appeared only once per node.
Insert / update nodes with module "Feed import";

Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /var/www/new_harbinger/sites/all/modules/contrib/taxonomy_menu/taxonomy_menu.module).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /var/www/new_harbinger/includes/entity.inc).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 354 of /var/www/new_harbinger/includes/entity.inc).
Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /var/www/new_harbinger/sites/all/modules/contrib/taxonomy_menu/taxonomy_menu.module).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /var/www/new_harbinger/includes/entity.inc).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 354 of /var/www/new_harbinger/includes/entity.inc).
Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /var/www/new_harbinger/sites/all/modules/contrib/taxonomy_menu/taxonomy_menu.module).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /var/www/new_harbinger/includes/entity.inc).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 354 of /var/www/new_harbinger/includes/entity.inc).
Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /var/www/new_harbinger/sites/all/modules/contrib/taxonomy_menu/taxonomy_menu.module).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /var/www/new_harbinger/includes/entity.inc).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 354 of /var/www/new_harbinger/includes/entity.inc).

Comment	File	Size	Author
#3	taxonomy_menu.module-1811850-2.patch	740 bytes	sergiu.savva
#1	taxonomy_menu.module-1811850-1.patch	603 bytes	sergiu.savva

Comments

Comment #1

sergiu.savva commented 13 October 2012 at 15:41

Status	File	Size
new	taxonomy_menu.module-1811850-1.patch	603 bytes

this works for me

-    $term = taxonomy_term_load($tid);
+    if (!$term = taxonomy_term_load($tid)) {
+      continue;
+    }

Comment #2

hles commented 13 October 2012 at 18:24

Status:

Active

» Needs review

Comment #3

sergiu.savva commented 15 October 2012 at 07:04

Status	File	Size
new	taxonomy_menu.module-1811850-2.patch	740 bytes

added some comments

   foreach ($terms as $key => $tid) {
-    $term = taxonomy_term_load($tid);
+
+    // taxonomy_term_load($tid) return FALSE if the term was not found
+    // if taxonomy $term is false, then go to the next $term
+    if (!$term = taxonomy_term_load($tid)) {
+      continue;
+    }

Comment #4

hles commented 15 October 2012 at 11:04

Do you have information on why it would return FALSE in the first place ? Maybe if the term should not be processed (depending on the answer of the question before), it should not done silently.

Comment #5

sergiu.savva commented 15 October 2012 at 11:42

If the term has been removed and term_id remain in the node when we call taxonomy_term_load($tid) function returns FALSE

Comment #6

hles commented 4 November 2012 at 19:03

Priority:

Normal

» Minor

FYI this fix is already part of 7.x-2.x branch.

Comment #7

sergiu.savva commented 6 November 2012 at 15:33

thx
in anticipation of the new release

Comment #8

jenlampton

she / her

commented 27 November 2012 at 22:57

Priority:	Minor	» Major
Status:	Needs review	» Reviewed & tested by the community

Saving a node on my site currently generates about 24 warnings and 24 notices (48 error messages) because of this bug. It's certainly not minor, but I'm glad that it's already been fixed in the next release. Can't wait to upgrade :)

It can be replicated by adding a taxonomy term reference field to a node where terms in that vocabulary are in the taxonomy menu. The field type should be checkboxes, and the errors will appear when the checkboxes are left unchecked. Two for each empty checkbox.

This patch prevents these errors on my pages when nodes are saved :) Thank you @sergiu.savva

Comment #9

deanflory commented 5 April 2013 at 20:09

After updating to Drupal 7.22 yesterday, I'm now getting these errors (and a lot more from other modules). This module's project page states the 2.x version is not ready for production yet but this issue states the fix for this is in the 2.x version. Should I use v2.x?

Here's the errors I'm getting that include the original poster's error plus a few more that may be related:

• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 487 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 488 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 489 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc).
• Notice: Trying to get property of non-object in _taxonomy_menu_nodeapi_helper() (line 490 of /.../sites/all/modules/taxonomy_menu/taxonomy_menu.module).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /.../includes/entity.inc).
• Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /.../includes/entity.inc