We have provision_drupal_sync_site() but no provision_drupal_sync_site_BACK()

The file platform/backup.provision.inc does does have some code to sync back all remote changes from a site.
Which I would like to generalize.

I'm hoping such changes will improve the overall code quality of provision and make changes such as #1205458: Move modules/themes/libraries/files/private directories out of /sites/example.com and #1083366: Make the spokes authoritative for files/ and private/ directories easier.

CommentFileSizeAuthor
provision-provision_drupal_sync_site_back.patch1.81 KBhelmo

Comments

anarcat’s picture

anarcat commented
Status: Active » Needs review

Please mark issues with patches as needs review. Thanks for the patch, it looks sound.

helmo’s picture

helmo commented

Please have a look at this...

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

I have committed this as is, because it's been blocking other issues for so long. But i'm not sure where this naming scheme is heading... "sync" is neutral, it has no sense of direction. So adding "_back" only adds to the confusion. Should we have _upload() and _download() hooks instead?

helmo’s picture

helmo commented

Although sync is neutral we mostly use it to mean push.

We do have fetch() methods, maybe we should use that and 'push'.

anarcat’s picture

anarcat commented

Agreed, do you want to take on the rename? We need to open an issue and do this in 2.x, which means replacing all occurences and updating the upgrade path docs.

helmo’s picture

helmo commented

I've opened #1945950: Rename provision_drupal_sync_site_back() as a followup.

iztok’s picture

iztok commented

Is there a way to sync from remote to master in 6.x-1.x version, maybe addon?

helmo’s picture

helmo commented

@Iztok: I don't understand your question, but this issue is about a small refactoring of a function, and probably not the best place to ask. Please open a new issue, of checkout the community site

helmo’s picture

helmo commented
Status: Fixed » Reviewed & tested by the community

@anarcat: I can't find this in git. Could it be that it was never pushed?

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Fixed

It sure looks like I forgot to push it - sorry! Just did.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 9d9e355 on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat: 
    Issue #1812338 by helmo: Refactor sync back.